Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tox_harness should honor the new common check exclusion list #27550

Closed
scbedd opened this issue Nov 11, 2022 · 2 comments
Closed

tox_harness should honor the new common check exclusion list #27550

scbedd opened this issue Nov 11, 2022 · 2 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.

Comments

@scbedd
Copy link
Member

scbedd commented Nov 11, 2022

For context, the common check list is defined in @kristapratico's PR #26704 that centralizes our exclusion lists.

Currently our tox_harness blindly invokes each set of tox environments as defined for the pipeline. It iterates across each package in the service, and invokes them in parallel.

for package in service:
  tox -e whl,sdist,mindependency -p all ...

Unfortunately, this means that for an environment that is a check like pylint or pyright, we need to install stuff only to SKIP IT.

Now that we have a centralized skip location, we should honor it automatically in tox_harness.py and omit skip tox environments from the call..up to entirely skipping the tox call entirely if all requested checks are skipped. This will save ourselves the installation time of those checks that would have been skipped anyway.

@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Nov 11, 2022
@scbedd scbedd self-assigned this Nov 11, 2022
@scbedd scbedd transferred this issue from Azure/azure-sdk-tools Nov 17, 2022
@scbedd scbedd moved this from 🤔Triage to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Nov 17, 2022
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 17, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'Storage:0.22307134,Azure.Core:0.12598448,Service Bus:0.09513172'

@scbedd
Copy link
Member Author

scbedd commented Nov 17, 2022

Resolved by #27487

@scbedd scbedd closed this as completed Nov 17, 2022
Repository owner moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Nov 17, 2022
@scbedd scbedd moved this from 🎊Closed to 🔬Dev in PR in Azure SDK EngSys 🚢🎉 Nov 17, 2022
@kurtzeborn kurtzeborn moved this from 🔬Dev in PR to 🎊Closed in Azure SDK EngSys 🚢🎉 Nov 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team. needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team.
Projects
None yet
Development

No branches or pull requests

2 participants