Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename query APIs in Logs and Metrics Client #20829

Closed
srnagar opened this issue Sep 24, 2021 · 0 comments · Fixed by #20830
Closed

Rename query APIs in Logs and Metrics Client #20829

srnagar opened this issue Sep 24, 2021 · 0 comments · Fixed by #20830
Assignees
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query

Comments

@srnagar
Copy link
Member

srnagar commented Sep 24, 2021

To prepare for supporting resource-centric logs queries, make the following name changes to the query APIs in Logs and Metrics clients.

LogsQueryClient

def query_workspace(
            self, 
            workspace_id: str, 
            query: str, 
            *, 
            additional_workspaces: list[str] = ..., 
            include_statistics: bool = ..., 
            include_visualization: bool = ..., 
            server_timeout: int = ..., 
            timespan: Union[timedelta, tuple[datetime, timedelta], tuple[datetime, datetime]] = ..., 
            **kwargs
        ) -> Union[LogsQueryResult, LogsQueryPartialResult]

MetricsQueryClient

def query_resource(
            self, 
            resource_uri: str, 
            metric_names: list[str], 
            *, 
            aggregations: list[str] = ..., 
            filter: str = ..., 
            granularity: timedelta = ..., 
            max_results: int = ..., 
            metric_namespace: str = ..., 
            order_by: str = ..., 
            timespan: Union[timedelta, tuple[datetime, timedelta], tuple[datetime, datetime]] = ..., 
            **kwargs
        ) -> MetricsResult
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 24, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 24, 2021
@srnagar srnagar added this to the [2021] October milestone Sep 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@scottaddie scottaddie added Monitor Monitor, Monitor Ingestion, Monitor Query and removed Monitor - Query labels Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Monitor Monitor, Monitor Ingestion, Monitor Query
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants