Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Tables testsuite to new test proxy infra #20114

Closed
lmazuel opened this issue Aug 5, 2021 · 2 comments
Closed

Migrate Tables testsuite to new test proxy infra #20114

lmazuel opened this issue Aug 5, 2021 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Tables

Comments

@lmazuel
Copy link
Member

lmazuel commented Aug 5, 2021

Engsys team and our friend @scbedd worked on a new test proxy infra for all repos (for curious people the code is here, but it's not necessary to read it for this issue).

This means we are moving away from "azure-devtools" and the VCRPy integration to use the new system. This implies a few changes in the code for tests on each packages:

  • Change the inheritance from AzureTestCase to the new class
  • This may imply changing some "self.assertXXX" to assert keyword, since assertXXXX will become unavailable.
  • Rewrite as necessary the sanitizers (if any) of that package in call to the test proxy\
  • Record the tests with the new system (and remove the old recordings)
  • Investigate any "live only tests" if any to see if they would work with the new system

Onboarding documentation is being written right now by @mccoyp. Given this document will be new, this is open to feedback and feedback should be done. @mccoyp will also present the onboarding documentation on August 12th to the SDK team.

Work is done when tests are running entirely under the new testsystem, and there is no usage anywhere of AzureTestCase in the Tables testsuite, will all live pipeline green.

Tables SDK is here:
https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/tables/azure-data-tables

@lmazuel lmazuel added Client This issue points to a problem in the data-plane of the library. Tables labels Aug 5, 2021
@lmazuel lmazuel added this to the [2021] September milestone Aug 5, 2021
@scbedd
Copy link
Member

scbedd commented Aug 6, 2021

@YalinLi0312 please check out the branch integrate-proxy. @seankane-msft made a bunch of progress on this. @mccoyp picked up after is working on keyvault tests with this same effort.

@YalinLi0312
Copy link
Member

Fixed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Tables
Projects
None yet
Development

No branches or pull requests

3 participants