Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages should only be released if they will install successfully #19928

Closed
danieljurek opened this issue Jul 23, 2021 · 3 comments · Fixed by #20243, #20294 or #20547
Closed

Packages should only be released if they will install successfully #19928

danieljurek opened this issue Jul 23, 2021 · 3 comments · Fixed by #20243, #20294 or #20547
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@danieljurek
Copy link
Member

Test installing a package that is about to be released before publishing to the package manager to ensure that, among other things, dependencies within the same service are all published. The test should run in isolation so that dependencies from the same service are only available if they are already published to the package manager.

@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Jul 23, 2021
@ckairen ckairen linked a pull request Aug 12, 2021 that will close this issue
@ckairen ckairen reopened this Aug 13, 2021
@ckairen
Copy link
Member

ckairen commented Aug 13, 2021

@benbp
Copy link
Member

benbp commented Aug 20, 2021

Related to the bug fix:

We should understand more deeply why we are seeing a pip install delay, and verify if we can reproduce it locally (CC @scbedd for local scripting help). If we can't repro it locally, as is predicted, then we should figure out the difference, as adding a 10 minute delay to the release pipeline is something we should avoid if possible.

@ckairen ckairen reopened this Aug 20, 2021
@ckairen ckairen closed this as completed Aug 31, 2021
@weshaggard weshaggard reopened this Sep 3, 2021
@weshaggard
Copy link
Member

I would still like to follow-up on https://github.com/Azure/azure-sdk-for-python/pull/20294/files#r692482842. As it is currently implemented I don't believe there is any enforcement to ensure that the package we are trying to release is actually verified. We do Get-ChildItem "$(Pipeline.Workspace)/${{ parameters.ArtifactName }}/${{ parameters.Artifact.name }}/*.zip" but if there is some issue, like we change the layout in someway, we have no verification that ensures we don't quietly skip the update of the requirements and never verify the package we are planning to ship.

@ckairen ckairen linked a pull request Sep 4, 2021 that will close this issue
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
4 participants