Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve architects' review feedback for Key Vault #19123

Closed
7 tasks
heaths opened this issue Jun 5, 2021 · 0 comments · Fixed by #19099
Closed
7 tasks

Resolve architects' review feedback for Key Vault #19123

heaths opened this issue Jun 5, 2021 · 0 comments · Fixed by #19099
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone

Comments

@heaths
Copy link
Member

heaths commented Jun 5, 2021

Feedback from our architects:

  • Delete methods on the KeyVaultAccessControlClient should return None and ignore HTTP 404s.
  • KeyVaultRestoreOperation and KeyVaultSelectiveKeyRestoreOperation can be removed
  • KeyVaultBackupClient.begin_restore and .begin_selective_key_restore can be merged into a single method -- a key_name kwarg will determine the behavior
  • KeyVaultBackupOperation should only have a folder_url property
  • Restore operations should return LROPoller[None], and backup operations should return LROPoller[KeyVaultBackupOperation]
  • Instead of get_backup_status and get_restore_status, pollers should be rehydrate-able with a simplified continuation token (e.g. the value of the response's azure-asyncoperation header instead of a pickled PipelineResponse)
  • role_* parameter names should be shortened as much as possible without ambiguity

Feel free to update this issue with idiomatic feedback.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jun 5, 2021
@heaths heaths added this to the [2021] June milestone Jun 5, 2021
@heaths heaths changed the title Resole architects' review feedback for Key Vault Resolve architects' review feedback for Key Vault Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant