Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DigitalTwins] azure-mgmt-digitaltwins is missing a dev_requirements.txt file #15789

Closed
seankane-msft opened this issue Dec 14, 2020 · 6 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Digital Twins Mgmt This issue is related to a management-plane library. test-reliability Issue that causes tests to be unreliable

Comments

@seankane-msft
Copy link
Member

The azure-mgmt-digitaltwins library is missing the dev_requirements.txt file. Adding this file will fix the nightly CI failures

@seankane-msft seankane-msft added Client This issue points to a problem in the data-plane of the library. Mgmt This issue is related to a management-plane library. Digital Twins test-reliability Issue that causes tests to be unreliable labels Dec 14, 2020
@jsntcy
Copy link
Member

jsntcy commented Dec 17, 2020

@seankane-msft

@seankane-msft
Copy link
Member Author

@jsntcy the dev_requirements.txt file is required to have the nightly pipeline passing. This issue is more concerned about solving the nightly CI issues.

@changlong-liu
Copy link
Member

Hi @seankane-msft , may I know do we still need this dev_requirements.txt in pipeline? I see a later pipeline seems OK for current status: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=755229&view=results.

And we don't have test script for this azure-mgmt-digitaltwins package, so we should not need a dev_requirements.txt?

@seankane-msft
Copy link
Member Author

I am not on the Python team anymore, tagging @scbedd for more current information

@scbedd
Copy link
Member

scbedd commented Sep 28, 2021

@seankane-msft thanks sir, I'll pick up this thread.

@changlong-liu you only require a dev_requirements.txt if there are dependencies used by your test framework that are not defined as package dependencies. For most, this would mean azure-sdk-tools or azure-devtools. For this specific case, it looks like azure-mgmt-digitaltwins doesn't have tests (at least that's the case now), so you don't need a dev_requirements.txt.

IIRC mgmt-digitaltwins got updated recently right? probably why the errors disappeared. I feel like we can close this item.

@lmazuel lmazuel assigned msyyc and unassigned changlong-liu Nov 12, 2021
@xiangyan99
Copy link
Member

Close since azure-mgmt-digitaltwins does not have tests.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Digital Twins Mgmt This issue is related to a management-plane library. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

No branches or pull requests

6 participants