Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-mgmt-digitaltwins failing basic import #15590

Closed
scbedd opened this issue Dec 1, 2020 · 5 comments
Closed

azure-mgmt-digitaltwins failing basic import #15590

scbedd opened this issue Dec 1, 2020 · 5 comments
Assignees
Labels
Digital Twins Mgmt This issue is related to a management-plane library.

Comments

@scbedd
Copy link
Member

scbedd commented Dec 1, 2020

install the package -> import * from azure.mgmt.digitaltwins

INFO:root:Importing all modules from namespace [azure.mgmt.digitaltwins] to verify dependency
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/__init__.py", line 13, in <module>
    from ._azure_digital_twins_management_client import AzureDigitalTwinsManagementClient
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/_azure_digital_twins_management_client.py", line 16, in <module>
    from .operations import DigitalTwinsOperations
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/operations/__init__.py", line 12, in <module>
    from ._digital_twins_operations import DigitalTwinsOperations
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/operations/_digital_twins_operations.py", line 17, in <module>
    from .. import models
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/models/__init__.py", line 30, in <module>
    from ._models import CheckNameRequest
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/models/_models.py", line 88, in <module>
    class DigitalTwinsResource(Model):
  File "/home/vsts/work/1/s/sdk/digitaltwins/azure-mgmt-digitaltwins/.tox/depends/lib/python2.7/site-packages/azure/mgmt/digitaltwins/models/_models.py", line 128, in DigitalTwinsResource
    sku = DigitalTwinsSkuInfo()
NameError: name 'DigitalTwinsSkuInfo' is not defined

I will note that while the above error is from the py27 env. The failure occurred on all platforms.

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 1, 2020
@scbedd scbedd assigned jsntcy and changlong-liu and unassigned jsntcy Dec 1, 2020
@annatisch
Copy link
Member

Yeah this is a known issue - I believe the SDK in master is T1, and the currently published SDK is the T2 release that's being maintained in this branch:
https://github.com/Azure/azure-sdk-for-python/tree/release/v3/sdk/digitaltwins/azure-mgmt-digitaltwins

I'm not sure what the timeframe is for merging the T2 SDK into master.

@scbedd
Copy link
Member Author

scbedd commented Dec 1, 2020

Thanks for the heads up Anna! Do you think we could just merge the T2 one into master then?

The reason I ask, is you're saying that the currently published SDK is the T2 release, so we wouldn't be losing anything right?

All that being said I know there is a plan that the mgmt folks are working off of, and I don't want to mess with that if it incurs additional effort.

@annatisch
Copy link
Member

annatisch commented Dec 1, 2020

Yeah that would be my preference too - I don't like that master is broken. Though I will leave that to @changlong-liu :)

@changlong-liu changlong-liu added the Mgmt This issue is related to a management-plane library. label Dec 2, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 2, 2020
@changlong-liu
Copy link
Member

Hi @scbedd , @annatisch ,

The master branch code for digitaltwins is old and there are errors.
Digitialtwins is currently released as Track1, so the latest code is in release/v3 branch.

I tend to delete the digitaltwins code in master branch to avoid this confusing. And adding @msyyc to know this.

@changlong-liu
Copy link
Member

Closing this issue since new digitaltwins has been released.
CC to @msyyc

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Digital Twins Mgmt This issue is related to a management-plane library.
Projects
None yet
Development

No branches or pull requests

4 participants