Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] ATOM API: Allow configuring "rule" while creating subscription #15171

Closed
HarshaNalluru opened this issue Nov 9, 2020 · 4 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Nov 9, 2020

.NET SDK provides CreateSubscription overload which allows configuring the rule.

public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CancellationToken cancellationToken = default);
public virtual Task<Response<SubscriptionProperties>> CreateSubscriptionAsync(CreateSubscriptionOptions options, CreateRuleOptions rule, CancellationToken cancellationToken = default);

This issue is to track adding support for the same in Python V7 SDK.

This feature is important because..
While creating a new subscription to an active topic(messages are actively being sent), there is no way users can stop filling up the subscription before the rule filter is added(since the default rule filter is TRUE).

Original issue: Azure/azure-sdk-for-js#12345

@KieranBrantnerMagee @yunhaoling @rakshith91 @ramya-rao-a

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels Nov 9, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 9, 2020
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Nov 9, 2020
@ramya-rao-a
Copy link
Contributor

Moving the milestone to Backlog as this can be added in the next semester as well. Please feel free to add details on how to approach this task and add the "help wanted" label

@lmazuel lmazuel added the Messaging Messaging crew label Apr 12, 2021
@lmazuel
Copy link
Member

lmazuel commented Apr 13, 2022

Given this operation is available in ARM, we'll update the docstring of the DP operation to suggest to use the ARM API for creation of subcscription with rules, and close the issue.
cc @kashifkhan

@lmazuel lmazuel modified the milestones: Backlog, [2022] July Apr 13, 2022
@lmazuel lmazuel modified the milestones: 2022-07, 2022-11 Sep 6, 2022
@Zobozodiac
Copy link

Can we please have this added to the python sdk, it’s a standard thing in the azure sdk’s for the other languages as linked above in javascript?

@kristapratico kristapratico removed this from the 2022-11 milestone Aug 17, 2023
Copy link

Hi @HarshaNalluru, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 15, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew Service Bus
Projects
None yet
Development

No branches or pull requests

6 participants