Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline when it hits a long retry #14701

Closed
tasherif-msft opened this issue Oct 22, 2020 · 0 comments · Fixed by #14629
Closed

Fix pipeline when it hits a long retry #14701

tasherif-msft opened this issue Oct 22, 2020 · 0 comments · Fixed by #14629
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@tasherif-msft
Copy link
Contributor

There are currently two edge cases where the request may fail where it could have passed. These edge cases can be handled by simply moving the policies around.

Case 1:
This case is related to the StorageHeadersPolicy. In this policy the current_time is set. This policy is currently ran before the retry policy. This means that if the retry policy was retrying and the time period has exceeded 15 min difference between the pre-established current_time it would fail as it would be considered an outdated request on the server side.

Solution Move the headers policy after RetryPolicy, i.e, current time would get reset with every retry.

Case 2:
This case is related to the StorageCredentialPolicy, moving it after the retry policy means that the TokenCredential can be refreshed if it has expired while retrying.

@tasherif-msft tasherif-msft added the Mgmt This issue is related to a management-plane library. label Oct 22, 2020
@tasherif-msft tasherif-msft self-assigned this Oct 22, 2020
@tasherif-msft tasherif-msft added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) and removed Mgmt This issue is related to a management-plane library. labels Oct 22, 2020
@tasherif-msft tasherif-msft changed the title Fix built pipeline when it hits a long retry Fix pipeline when it hits a long retry Oct 22, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant