Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomVision - CustomVisionTrainingClient can not be imported from azure.cognitiveservices.vision.customvision #11504

Closed
iMicknl opened this issue May 18, 2020 · 4 comments · Fixed by #12225
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Custom Vision Service Attention Workflow: This issue is responsible by Azure service team.

Comments

@iMicknl
Copy link
Member

iMicknl commented May 18, 2020

  • Package Name: Custom Vision
  • Package Version: 2.0.0
  • Operating System: Linux
  • Python Version: 3.6

Describe the bug
azure-cognitiveservices-vision-customvision 2.0.0 on PyPi mentions:

CustomVisionTrainingClient cannot be imported from `azure.cognitiveservices.vision.customvision.training anymore` (import from `azure.cognitiveservices.vision.customvision` works like before)

To Reproduce
Steps to reproduce the behavior:
from azure.cognitiveservices.vision.customvision import CustomVisionTrainingClient

ImportError: cannot import name 'CustomVisionTrainingClient'

Importing it from azure.cognitiveservices.vision.customvision.training works.

Expected behavior
Importing from azure.cognitiveservices.vision.customvision should work, or it should be updated in the documentation.

Additional context
Related to #11503

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2020
@kaerm kaerm added bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive Services Service Attention Workflow: This issue is responsible by Azure service team. labels May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dfulcer.

@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 18, 2020
@RodgeFu
Copy link
Member

RodgeFu commented May 21, 2020

An issue in changelog tool to generate the doc? + @lmazuel to confirm. thanks.

@zikalino
Copy link

zikalino commented May 21, 2020

@RodgeFu this is not an issue with the tool. Currently we use template for general breaking changes and modify it manually to suit particular release (client names etc.). So yes, it's error prone...
Perhaps general breaking changes should be automatically generated by changelog tool as well.

The proper string in this case should be:

CustomVisionPredictionClient cannot be imported from azure.cognitiveservices.vision.customvision.prediction .custom_vision_training_client anymore (import from azure.cognitiveservices.vision.customvision .training works like before)
I can make additional release to fix the wording.

@ghost
Copy link

ghost commented Jun 24, 2020

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @areddish, @tburns10.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. Cognitive - Custom Vision Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants