Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Preparer infrastructure should have tests for cache management #10351

Closed
KieranBrantnerMagee opened this issue Mar 17, 2020 · 1 comment
Closed

Test Preparer infrastructure should have tests for cache management #10351

KieranBrantnerMagee opened this issue Mar 17, 2020 · 1 comment
Assignees
@KieranBrantnerMagee
Labels
Client This issue points to a problem in the data-plane of the library.

Comments

@KieranBrantnerMagee
Copy link
Member

Per the work here the test preparer infrastructure has become much more complicated, and as such should probably be validated more robustly.

Add tests of some sort to ensure proper functionality going forward.
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Mar 17, 2020
@KieranBrantnerMagee KieranBrantnerMagee mentioned this issue Mar 17, 2020
Merged
@kaerm kaerm added the Client This issue points to a problem in the data-plane of the library. label Mar 17, 2020
@KieranBrantnerMagee
Copy link
Member Author

Unit tests have been added (We ended up glomming it into the existing PR) so this issue can be closed.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaerm @KieranBrantnerMagee