Skip to content

Latest commit

 

History

History
137 lines (100 loc) · 6.69 KB

recording_migration_guide.md

File metadata and controls

137 lines (100 loc) · 6.69 KB
Raw

Guide for migrating test recordings out of the azure-sdk-for-python repository

The Azure SDK test proxy enables tests to run recorded tests, even when these test recordings are outside the azure-sdk-for-python repository. Migrating to this out-of-repo recording setup requires an initial recording move, and after this the flow to update recordings will be slightly different. This guide describes the first stage of this process and links to updated recording instructions.

More technical documentation of the test proxy's out-of-repo recording support can be found here in the azure-sdk-tools repository.

Table of contents

Current recording setup

Currently, test recordings live in the azure-sdk-for-python repository (or "language repo"), under a given package's /tests/recordings directory. The test proxy loads recordings from this local directory -- this can be done entirely offline.

However, the main drawback of storing recordings in the language repo is bloat; a huge percentage of all language repo files are actually test recordings. Recording file updates are also included in pull requests, which can make them more tedious to review and difficult to load.

New recording setup

With the test proxy, we can instead store recordings in a completely different git repository (called azure-sdk-assets, or the "assets repo"). The test proxy creates a sparse clone of only the recordings for the package being tested, stores them locally in a git-excluded language repo directory, and runs playback tests in the same way as before.

The out-of-repo recording system requires a connection to fetch recordings but frees up considerable space in the language repo. Additionally, pull requests that update recordings now update a single pointer to new recordings instead of full recording files.

The pointer to test recordings is stored in a new assets.json file that will be created for each package during the initial migration.

Initial recording migration

A PowerShell script in the azure-sdk-tools repository will assist in pushing recordings to the assets repo, removing recordings from the language repo, and creating an assets.json file for the package you're migrating.

This script -- generate-assets-json.ps1 -- should be run once per package.

Migration script prerequisites

  • The targeted library is already migrated to use the test proxy.
  • The test proxy is available locally, with an executable inside a .proxy folder at the root of your Python repo.
    • If the tool isn't present, it'll be automatically set up by running the library's tests in playback mode.
  • Git version > 2.30.0 is to on the machine and in the path. Git is used by the script and test proxy.
  • PowerShell Core >= 7.0 is installed.
  • Global git config settings are configured for user.name and user.email.
    • These settings can be overridden with environment variables GIT_COMMIT_OWNER and GIT_COMMIT_EMAIL, respectively.
  • Membership in the azure-sdk-write GitHub group.

Execute the migration script

In a PowerShell window:

  1. Add the test proxy executable to PATH if it's not already present. This can be done by adding the path to the .proxy folder at the base of your Python repo. You can add the test proxy to PATH for the current session by running the following:
  • On Windows:
$env:PATH += ';<path-to-repo>\azure-sdk-for-python\.proxy'
  • On Mac or Linux:
$env:PATH += ':<path-to-repo>/azure-sdk-for-python/.proxy'

  1. Run echo $env:PATH to inspect PATH and confirm that the proxy path was correctly appended.

  2. Set your working directory to the root of the package you're migrating (sdk/{service}/{package}) -- for example:

cd <path-to-repo>\azure-sdk-for-python\sdk\keyvault\azure-keyvault-keys
  1. Run the following command:
..\..\..\eng\common\testproxy\onboarding\generate-assets-json.ps1 -InitialPush

If you run git status from within the language repo, you should see:

  • Deleted files for each test recording in the package
  • A new assets.json file under the root of your package

The assets.json file will have the form:

{
  "AssetsRepo": "Azure/azure-sdk-assets",
  "AssetsRepoPrefixPath": "python",
  "TagPrefix": "python/{service}/{package}",
  "Tag": "python/{service}/{package}_<10-character-commit-SHA>"
}

The Tag field matches the name of a tag that's been created in the assets repo and contains the uploaded recordings. Before creating a PR to cement the recording move, it's a good idea to check out that tag in the assets repo and make sure the recordings that you expect to see are there.

Run tests with out-of-repo recordings

After moving recordings to the asset repo, live and playback testing will be the same as it was in the past. The test proxy automatically pulls down the correct set of recordings based on the Tag in your package's assets.json file.

The process for updating test recordings is slightly different than it was with in-repo recordings, and differs in two primary ways:

  1. When tests are run in recording mode, recording changes won't be visible in the language repo and will instead be tracked in a separate directory.
  2. When updated recordings are pushed to the assets repo, the Tag field in your package's assets.json file will be updated to point to these new recordings. This assets.json change is what you'll include in a pull request to update recordings in the language repo.

For more details, refer to the documentation in tests.md.