Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

Fix first code section in Service Bus files #504

Closed
jcookems opened this issue Jun 20, 2012 · 5 comments
Closed

Fix first code section in Service Bus files #504

jcookems opened this issue Jun 20, 2012 · 5 comments

Comments

@jcookems
Copy link
Contributor

There are a number of differences between the Service Bus files and those for other services:

  1. In the following files in ...\tests\unit\WindowsAzure\Common\Internal\Atom\

    • AtomLinkTest.php
    • ContentTest.php
    • EntryTest.php
    • FeedTest.php
    • PersonTest.php
    • SourceTest.php
      Need to replace
      • @package Tests\Unit\WindowsAzure\Services\Queue\Models
        with
      • @package Tests\Unit\WindowsAzure\Common\Internal\Atom
  2. In ...\tests\unit\WindowsAzure\Common\Internal\Filters\WrapFilterTest.php, need to

    • Add a namespace (Tests\Unit\WindowsAzure\Common\Internal\Filters)
    • Change the @package to match that namespace.
  3. In the following files in ...\tests\unit\WindowsAzure\ServiceBus\

    • ServiceBusRestProxyTest.php
    • ServiceBusServiceTest.php
    • ServiceBusSettingsTest.php
    • WrapRestProxyTest.php
    • WrapServiceTest.php
    • Internal\WrapTokenManagerTest.php

    Need to make the first comment in sync with the other test comments:

    • Placement of the "PHP version 5"
    • Add @category
    • Remove a space between the attributes and the text, so there is a single space after @copyright
  4. Almost all the files in ...\tests\unit\WindowsAzure\ServiceBus\models\ have incorrect text in the @Package sections (Tests\Unit\WindowsAzure\Services\Queue\Models). They should all be:

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models
  5. Almost all the files in ...\WindowsAzure\Common\Internal\Atom\ have the following problems:

    • Incorrect text in the @package sections (WindowsAzure\ServiceBus\Internal\Atom). They should all be:
      • @package WindowsAzure\Common\Internal\Atom
    • There is a double semicolon "... Version 2.0 (the "License");;", it must be removed.
  6. In ...\WindowsAzure\ServiceBus\WrapRestProxy.php, the @author tag incorrect (azurephp@microsoft). It should be

  7. In ...\WindowsAzure\ServiceBus\Internal\IServiceBus.php, there is a double semicolon "... Version 2.0 (the "License");;", it must be removed.

  8. In ...\WindowsAzure\ServiceBus\Internal\IWrap.php, the @author tag incorrect (azurephp@microsoft). It should be

@ghost ghost assigned gcheng Jun 20, 2012
@gcheng
Copy link
Contributor

gcheng commented Jun 20, 2012

all fixed now.

@gcheng gcheng closed this as completed Jun 20, 2012
@jcookems jcookems reopened this Jun 21, 2012
@jcookems
Copy link
Contributor Author

Still some issues:

  1. Almost all the files in ...\WindowsAzure\Common\Internal\Atom\ have incorrect license text, with a double semicolon.
      Need to replace
      * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
      
      with 
      * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");

  2. In ...\tests\unit\WindowsAzure\Common\Internal\Atom\EntryTest.php
    Need to replace

    • @package Tests\Unit\WindowsAzure\Core\Atom

      with

    • @package Tests\Unit\WindowsAzure\Common\Internal\Atom

  3. In the following files in ...\tests\unit\WindowsAzure\ServiceBus\

    • ServiceBusServiceTest.php
    • WrapServiceTest.php

    Need to replace

    • @package Tests\Unit\WindowsAzure\Queue

      with

    • @package Tests\Unit\WindowsAzure\ServiceBus

  4. Almost all the files in ...\tests\unit\WindowsAzure\ServiceBus\models\ have incorrect text in the @Package sections.
    Need to replace

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models\

    with

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models
  5. In ...\tests\unit\WindowsAzure\Common\Internal\Atom\CreateRuleResultTest.php
    Need to replace

    • @package Tests\Unit\WindowsAzure\Services\Rule\Models

      with

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models

  6. In ...\tests\unit\WindowsAzure\Common\Internal\Atom\CreateSubscriptionResultTest.php
    Need to replace

    • @package Tests\Unit\WindowsAzure\Services\Subscription\Models

      with

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models

  7. In ...\tests\unit\WindowsAzure\Common\Internal\Atom\CreateTopicResultTest.php
    Need to replace

    • @package Tests\Unit\WindowsAzure\Services\Topic\Models

      with

    • @package Tests\Unit\WindowsAzure\ServiceBus\Models

  8. Almost all the files in ...\WindowsAzure\Common\Internal\Atom\ have incorrect text in the @Package sections.
    Need to replace

    • @package WindowsAzure\ServiceBus\Internal\Atom

    with

    • @package WindowsAzure\Common\Internal\Atom

@gcheng
Copy link
Contributor

gcheng commented Jun 21, 2012

fix ready.

@jcookems
Copy link
Contributor Author

Still some problems:

~\WindowsAzure\Common\Internal\Atom\AtomBase.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

~\WindowsAzure\Common\Internal\Atom\AtomLink.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

~\WindowsAzure\Common\Internal\Atom\Category.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

~\WindowsAzure\Common\Internal\Atom\Content.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

~\WindowsAzure\Common\Internal\Atom\Entry.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom

~\WindowsAzure\Common\Internal\Atom\Feed.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom

~\WindowsAzure\Common\Internal\Atom\Generator.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

~\WindowsAzure\Common\Internal\Atom\Person.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom

~\WindowsAzure\Common\Internal\Atom\Source.php

...

* LICENSE: Licensed under the Apache License, Version 2.0 (the "License");;
< * LICENSE: Licensed under the Apache License, Version 2.0 (the "License");
...
* @Package WindowsAzure\ServiceBus\Internal\Atom
< * @Package WindowsAzure\Common\Internal\Atom
...

@gcheng
Copy link
Contributor

gcheng commented Jun 21, 2012

all fixed now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants