[Service Bus] Caching AMQP messages within AmqpMessageBatch #30305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
m-redding
commented
Aug 4, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageBatch.cs
Outdated
Show resolved
Hide resolved
m-redding
commented
Aug 4, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Show resolved
Hide resolved
m-redding
commented
Aug 4, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
|
API change check API changes are not detected in this pull request. |
|
/azp run net - servicebus- tests |
|
No pipelines are associated with this pull request. |
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpClient.cs
Outdated
Show resolved
Hide resolved
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jsquire
reviewed
Aug 4, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpClient.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageBatch.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageBatch.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Core/TransportMessageBatch.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: JoshLove-msft <[email protected]>
…ssageBatch.cs Co-authored-by: Jesse Squire <[email protected]>
|
This pull request is protected by Check Enforcer. |
jsquire
reviewed
Aug 9, 2022
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusMessageBatch.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpMessageConverter.cs
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Diagnostics/EntityScopeFactory.cs
Outdated
Show resolved
Hide resolved
sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs
Outdated
Show resolved
Hide resolved
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…sSender.cs Co-authored-by: JoshLove-msft <[email protected]>
…tyScopeFactory.cs Co-authored-by: JoshLove-msft <[email protected]>
|
/azp run net - servicebus - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JoshLove-msft
approved these changes
Aug 18, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
) * switching to amqp batch * changing readonly type * updating model factory * making AmqpMessageConverter mockable * big test revamp * restructuring AmqpMessageBatchTests * fixing reserved size overhead * additional tests * disposing amqp message * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Amqp/AmqpClient.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Core/TransportMessageBatch.cs Co-authored-by: Jesse Squire <[email protected]> * indent * additional tests * removing servicebusmessages from batch pt 1 * remove sb messages from batch pt 2 * test updates * additional test updates * additional formatting and tests * last test fix * build fix * fixing size calculation * small test update * Update sdk/servicebus/Azure.Messaging.ServiceBus/tests/Amqp/AmqpSenderTests.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Primitives/ServiceBusModelFactory.cs Co-authored-by: JoshLove-msft <[email protected]> * fixing field names * test updates * removing diagnostics update * test updates * feedback updates + test updateS * static property * name change to default * moving rule manager methods * remove duplicate instrumentation * removing unnecessary code * test fix * removing unnecessary code * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Sender/ServiceBusSender.cs Co-authored-by: JoshLove-msft <[email protected]> * Update sdk/servicebus/Azure.Messaging.ServiceBus/src/Diagnostics/EntityScopeFactory.cs Co-authored-by: JoshLove-msft <[email protected]> * small updates * small change * Switching method to private Co-authored-by: JoshLove-msft <[email protected]> Co-authored-by: Jesse Squire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main focus of the changes here is to implement the changes in
AmqpMessageBatchin Service Bus that have already been made to theEventDataBatchin Event Hubs. Rather than serializing eachServiceBusMessagetwice before send (once to measure size, and once to actually send), the improvedAmqpMessageBatchsimply serializes them and clones theAmqpMessageinstance, allowing for a more efficient batching experience.See #28866
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.