Add ClientId to DAC Options #23680
Merged
Add ClientId to DAC Options #23680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christothes
requested review from
KrzysztofCwalina,
schaabs and
tg-msft
as code owners
ghost
added
the
Closed
10 tasks
schaabs
reviewed
Sep 3, 2021
sdk/identity/Azure.Identity/api/Azure.Identity.netstandard2.0.cs
Outdated
Show resolved
Hide resolved
schaabs
reviewed
Sep 8, 2021
| /// <summary> | ||
| /// Specifies the client id of the selected credential | ||
| /// </summary> | ||
| public string InteractiveBrowserCredentialClientId { get; set; } |
There was a problem hiding this comment.
should we default this to Constants.DeveloperSignOnClientId since that is the client id which will be used if the user doesn't set this?
There was a problem hiding this comment.
We do that here:
schaabs
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.