Release Azure.ResourceManager.KeyVault #22367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
* deprecated api * improve downloadcontent and download streaming * wip
* updates * Update sdk/textanalytics/Azure.AI.TextAnalytics/README.md Co-authored-by: Krista Pratico <[email protected]> Co-authored-by: Krista Pratico <[email protected]>
…zure#21988) * Mark EventListener using tests as non-parallelizable * Adjust test that throws exceptions from indexing action handlers Reduce number of documents used in the test so that EventSource does not log a very large number of events. * Do not create proxies from proxies * Fix more tests to avoid event exceptions * Use GetOriginal() helper method when creating proxies
* Generate AKS SDK for 2021-05-01 API * Remove deprecated test * Update package info * Update test record Co-authored-by: Kaiqi Zhang <[email protected]>
# All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [ ] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [ ] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [ ] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [ ] Title of the pull request is clear and informative. - [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [ ] Pull request includes test coverage for the included changes. ### [SDK Generation Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#sdk-generation-guidelines) - [ ] The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only) - [ ] The `*.csproj` and `AssemblyInfo.cs` files have been updated with the new version of the SDK. Please double check nuget.org current release version. ## Additional management plane SDK specific contribution checklist: Note: Only applies to `Microsoft.Azure.Management.[RP]` or `Azure.ResourceManager.[RP]` - [ ] Include updated [management metadata](https://github.com/Azure/azure-sdk-for-net/tree/main/eng/mgmt/mgmtmetadata). - [ ] Update AzureRP.props to add/remove version info to maintain up to date API versions. ### Management plane SDK Troubleshooting - If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add `new service` label and/or contact assigned reviewer. - If the check fails at the `Verify Code Generation` step, please ensure: - Do not modify any code in generated folders. - Do not selectively include/remove generated files in the PR. - Do use `generate.ps1/cmd` to generate this PR instead of calling `autorest` directly. Please pay attention to the @microsoft.csharp version output after running `generate.ps1`. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version. **Note: We have recently updated the PSH module called by `generate.ps1` to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command**: `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules` ### Old outstanding PR cleanup Please note: If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.
* Change the accessbility to virtual for Resource.Id * Catch TargetInvocationException in interceptor Co-authored-by: m-nash <[email protected]> Co-authored-by: m-nash <[email protected]>
…failures generating new SDKs (Azure#21765) * Update DataCollectionRulesTests.cs commenting out the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK. * Update DataCollectionRulesTests.cs Commenting this the DataCollectionRulesTests because DataCollectionRules have a different error response format from everything else in AzureMonitor and so they can't be built with this SDK.
* Limit number of events stored in TestEventListener * Throw exception when events are dropped Increase default max event count to 1000. * Dispose the event listener in AzureIdentityEventSourceTests * Add comments on TestEventListener ctor * Dispose TestEventListener in a timely manner * Use method local TestEventListener in Search
* Add JsonConverter for ResourceIdentity * Feedback * Format file
…#21789)" (Azure#22471) This reverts commit d8cc63a.
* wip changes to add common rest api * update variable name * address pr comments * update recording
Reason: The ACS SDKs (including Identity) are being handed over to the respective service teams.
* Add interop sample * File header * PR FB
Increment package version after release of Azure.Core.Amqp
Partial fix for Azure#22413
* Service Bus extension API updates * MaxEventBatchSize
ArcturusZhang
requested review from
danieljurek,
digimaun,
drwill-ms,
heaths,
jamdavi,
jfggdl,
JoshLove-msft,
jsquire,
kinelski,
Kishp01,
KrzysztofCwalina,
LarryOsterman,
m-nash,
maririos,
markcowl,
mitchdenny,
nisha-bhatia,
pakrym,
ryogok,
schaabs,
serkantkaraca,
TFR258,
tg-msft,
timtay-microsoft,
vinagesh,
weshaggard and
YalinLi0312
as code owners
|
/check-enforcer override |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Mar 22, 2023
[Hub Generated] Review request for Microsoft.Quota to add version stable/2023-02-01 (Azure#22367) * Adds base for updating Microsoft.Quota from version preview/2021-03-15-preview to version 2023-02-01 * Updates readme * Updates API version in new specs and examples * Fix version in readme * Remove stale version, update readme * Mark parameter as optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.