Don't hardcode runsettings if built from VS

[kasobol-msft]

Attempt to fix #20674 .

The <RunSettingsFilePath Condition="'$(RunSettingsFilePath)' == ''">$(RepoEngPath)\nunit.runsettings</RunSettingsFilePath> didn't work :-(

https://docs.microsoft.com/en-us/previous-versions/visualstudio/visual-studio-2015/msbuild/visual-studio-integration-msbuild?view=vs-2015&redirectedfrom=MSDN#building-solutions

[pakrym]

I was hoping to teach people to switch settings by commenting/uncomenting lines in the centralized file.

[kasobol-msft]

I was hoping to teach people to switch settings by commenting/uncomenting lines in the centralized file.

Maybe we can also AND this with some env variable to make it opt-in.
I find editing a file far less pleasant experience than clicking a checkbox to select between few prepared files... (prepared from centarlized file of course by filling these commented out gaps).

[pakrym]

There seems to be another variable for runsettings location:

Can you see whether VS uses that one instead?

[kasobol-msft]

I tried <RunSettingsFilePath Condition="'$(VSTestSetting)' == ''">$(RepoEngPath)\nunit.runsettings</RunSettingsFilePath> without luck. However by looking at that snippet - shouldn't VSTestSetting take precedence over RunSettingsFilePath if that VS were using that one?

https://docs.microsoft.com/en-us/visualstudio/test/configure-unit-tests-by-using-a-dot-runsettings-file?view=vs-2019#set-a-build-property

Looks like:

[kasobol-msft]

We'll follow up with VS team to seek better solution.