-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dns ZoneType Change #15236
Merged
Merged
Dns ZoneType Change #15236
Changes from 34 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
b2a4f14
WIP: Initial CRUD and List test for record and zone
bquantump 38b9eb1
WIP: Port of cloud issues
bquantump e15afb3
WIP: OneTimeTearDown and setup working. No double test runs
bquantump 4c799eb
WIP: don't make zone twice
bquantump 3f88fd3
WIP: Commit test
90204f1
WIP: Fix changelog and readme
bquantump ce4d0de
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump 6fee9cf
WIP: Fix yaml
bquantump 66d2634
WIP: Fix yml 2
bquantump a92d37c
WIP: Remove unused function
bquantump c0abf80
Remove .swp file
bquantump 8fed2c7
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump f34768b
Remove SWP file
bquantump 040df84
Update DNS Track 2 test
bquantump f28d520
Add Tests Recordings
bquantump 936583d
Fix Class name
bquantump 6cf295d
WIP: Update tests
bquantump 212e5c4
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump 88c43bf
WIP: Make exception test clearner
bquantump a3e2c57
WIP: Update live test records
bquantump 5cf8665
Revert json change
bquantump 556c220
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump becddf3
Small fixes
bquantump 932730f
WIP: Update SLN
bquantump 2c0317c
WIP: Dns gen update
bquantump 0f02877
Revert "WIP: Dns gen update"
bquantump 67eba6d
WIP: make zonetype obsolete
bquantump 0e2d874
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-net
bquantump bb4b9c6
WIP: make zone type readonly
bquantump 3520322
WIP: update test
bquantump f43c483
WIP: Make all private relate fields obsolete
bquantump 3ddd8b7
WIP: only change things we want to change
bquantump 3990ca9
Merge branch 'master' of https://github.com/bquantump/azure-sdk-for-net
bquantump 18738ce
WIP: Update test
bquantump 70bd17b
WIP: Update test
bquantump aa1154d
WIP: update test correctly
bquantump File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
sdk/dns/Azure.ResourceManager.Dns/src/Customization/Models/Zones.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
|
|
||
| // <auto-generated/> | ||
|
|
||
| #nullable disable | ||
|
|
||
| using System; | ||
| using System.Collections.Generic; | ||
|
|
||
| namespace Azure.ResourceManager.Dns.Models | ||
| { | ||
| /// <summary> Describes a DNS zone. </summary> | ||
| public partial class Zone : Resource | ||
| { | ||
| /// <summary> The type of this DNS zone (Public or Private). </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public ZoneType? ZoneType { get; } | ||
| /// <summary> A list of references to virtual networks that register hostnames in this DNS zone. This is a only when ZoneType is Private. </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public IList<SubResource> RegistrationVirtualNetworks { get; } | ||
| /// <summary> A list of references to virtual networks that resolve records in this DNS zone. This is a only when ZoneType is Private. </summary> | ||
| [Obsolete("Private DNS is not allowed in this API anymore, use the privatedns API")] | ||
| public IList<SubResource> ResolutionVirtualNetworks { get; } | ||
| } | ||
| } | ||
6 changes: 0 additions & 6 deletions
6
sdk/dns/Azure.ResourceManager.Dns/src/Generated/Models/Zone.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140 changes: 0 additions & 140 deletions
140
....ResourceManager.Dns/tests/SessionRecords/ScenarioTestsRecordSets/CreateGetMx()Async.json
This file was deleted.
Oops, something went wrong.
56 changes: 0 additions & 56 deletions
56
....ResourceManager.Dns/tests/SessionRecords/ScenarioTestsRecordSets/CreateGetNs()Async.json
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need [Obsolete] on these two properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm actually do want to do this? Since a user could want to view these and they would get a compile error trying to get these unless that suppress that warning?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are only read-only, so they would only come back from a GET on a private DNS zone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compile warning not error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think [Obsolete] can be applied here. If user is using these properties, they will get a compiler warning which is what we wanted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well depends on how one builds I suppose. Dotnet core on Ubuntu throws a compile error.
I will make this change.