Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage: Prefix FooServiceProperties types with Foo #7848

Closed
tg-msft opened this issue Oct 1, 2019 · 1 comment · Fixed by #7882
Closed

Storage: Prefix FooServiceProperties types with Foo #7848

tg-msft opened this issue Oct 1, 2019 · 1 comment · Fixed by #7882
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Milestone
Backlog

Comments

@tg-msft
Copy link
Member

tg-msft commented Oct 1, 2019

From the API Review, we should prefix all of the subtypes for BlobServiceProperties/QueueServiceProperties/FileServiceProperties with Blob/Queue/File.
@tg-msft tg-msft added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. labels Oct 1, 2019
@tg-msft tg-msft added this to the Backlog milestone Oct 1, 2019
@tg-msft
Copy link
Member Author

tg-msft commented Oct 1, 2019

Please note that Logging should be renamed to FooAnalyticsLogging to avoid confusion with client-side logging in Azure.Core.

@JoshLove-msft JoshLove-msft mentioned this issue Oct 2, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Prefix service property types with Blob/Queue/File. JoshLove-msft/azure-sdk-for-net
2 participants
@tg-msft @JoshLove-msft