Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ] Consider adding Azure.Security.KeyVault.Common project to Azure.Security.KeyVault #7041

Closed
annelo-msft opened this issue Jul 29, 2019 · 1 comment
Closed

[FEATURE REQ] Consider adding Azure.Security.KeyVault.Common project to Azure.Security.KeyVault #7041

annelo-msft opened this issue Jul 29, 2019 · 1 comment
Assignees
@AlexGhiondea
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault

Comments

@annelo-msft
Copy link
Member

Is your feature request related to a problem? Please describe.
Common functionality was duplicated across projects when adding version-to-string logic in PR 6915, specifically the GetVersionString method in KeyClientOptions.cs and SecretClientOptions.cs.

Describe the solution you'd like
Consider adding an Azure.Security.KeyValue.Common project to house code that's common across products.

Describe alternatives you've considered
For now, the code was copied across files.

Additional context

Information Checklist
Kindly make sure that you have added all the following information above and checkoff the required fields otherwise we will treat the issuer as an incomplete report

  • [ X] Description Added
  • [ X] Expected solution specified
@triage-new-issues triage-new-issues bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 29, 2019
@Petermarcu Petermarcu added the Client This issue points to a problem in the data-plane of the library. label Jul 29, 2019
@triage-new-issues triage-new-issues bot removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 29, 2019
@AlexGhiondea
Copy link
Contributor

We are sharing code via a shared code project. While having a common libraries might help, in this case they introduce another layer of dependency that we should try to avoid.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexGhiondea AlexGhiondea

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Petermarcu @AlexGhiondea @shahabhijeet @annelo-msft