Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Core should wrap all transport layer exceptions #6817

Closed
tg-msft opened this issue Jul 3, 2019 · 1 comment · Fixed by #7669
Closed

Azure.Core should wrap all transport layer exceptions #6817

tg-msft opened this issue Jul 3, 2019 · 1 comment · Fixed by #7669
Assignees
@pakrym
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
Sprint 157

Comments

@tg-msft
Copy link
Member

tg-msft commented Jul 3, 2019

If your network connection drops during the middle of a request, we should throw a RequestFailedException rather than an HttpRequestException that HttpClient throws.

Ideally customers won't have to know or care about which transport layer they're using.
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Jul 3, 2019
@tg-msft tg-msft added this to the Backlog milestone Jul 3, 2019
@AlexGhiondea AlexGhiondea mentioned this issue Aug 2, 2019
Closed
13 tasks
@AlexGhiondea AlexGhiondea modified the milestones: Backlog, Sprint 157 Aug 2, 2019
@pakrym
Copy link
Contributor

pakrym commented Sep 6, 2019

Include clientRequestId in messages.

@pakrym pakrym mentioned this issue Sep 10, 2019
Closed
18 tasks
@pakrym pakrym mentioned this issue Sep 18, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pakrym pakrym

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
Sprint 157
Development

Successfully merging a pull request may close this issue.

Wrap transport exceptions pakrym/azure-sdk-for-net
3 participants
@tg-msft @pakrym @AlexGhiondea