Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the EventBatch infrastructure #6791

Closed
jsquire opened this issue Jul 2, 2019 · 0 comments
Closed

Create the EventBatch infrastructure #6791

jsquire opened this issue Jul 2, 2019 · 0 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Jul 2, 2019

Summary

Historically, Event Hubs has allowed a batch of events with specified size limit to be prepared using a TryAdd-style interface. Because the size depends on the format of an event and event batch container as it would be transmitted, it is subject to change with the underlying transport and depends on the format used by that transport. Preview two will reintroduce this concept for the AMQP transport, using this as an opportunity to bring the message translation foundation forward from the track one implementation into track two.

Scope of Work

  • Implement the EventBatch type, allowing for a size-limited batch to be created.

  • Add an API to the producer to allow a new batch to be created, since it is bound to the transport, this creation must be done by the transport-specific client.

  • Translate and adapt the track one code for AMQP message translation from the EventData format, along with associated tests.

Out of Scope

  • Changes to any references within the TrackOneClient code; that will remain as-is.

  • Implementing the actual sending of event batches through the producer and the track two->track one translation of the EventDataBatch; that will be covered under a dedicated workstream.

Success Criteria

  • The EventHubProducer can create an EventHubBatch on request, with options configured to limit the size.

  • The EventHubBatch can adequately represent its size needed to be published; event data is translated to its wire format for AMQP to be measured.

  • The requisite tests have been implemented.

@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Jul 2, 2019
@jsquire jsquire added this to the Sprint 156 milestone Jul 2, 2019
@jsquire jsquire self-assigned this Jul 2, 2019
@jsquire jsquire closed this as completed Jul 24, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

1 participant