Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Apply link metadata for the maximum message batch size #44914

Open
jsquire opened this issue Jul 9, 2024 · 1 comment
Open
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone

Comments

@jsquire
Copy link
Member

jsquire commented Jul 9, 2024

Problem statement

When large message support is enabled, the standard message size limit is still applied to batched messages. At the time of writing, the Service Bus service rejects any batch larger than 1MB regardless of the configured maximum message size. Because the service communicates only the maximum message size allowed by the AMQP link, the client library is unable to set the actual limit on the batch, allowing developers to create batches that can never successfully be sent.

There is an open request for the service to add a new link property that exposes the maximum message batch size on an AMQP link so that callers can dynamically discover the service limits.

Current work-around

The constructor for AmqpSender is currently hardcoding the 1mb limit in order to ensure that the client library does not allow callers to create batches which cannot be successfully published.

Scope of work

  • Update AmqpSender to consume the maximum message batch size when a link is opened, following the same pattern used for the maximum message size, setting the MaxBatchSize property.

Success criteria

  • The MaxBatchSize property of AmqpSender is populated dynamically from AMQP link metadata and is updated each time a link is opened.
  • The Service Bus live test suite continues to pass reliably.

References and related

@jsquire jsquire added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 9, 2024
@jsquire jsquire added this to the Backlog milestone Jul 9, 2024
@jsquire jsquire moved this to Planned in Azure SDK for Service Bus Jul 9, 2024
@jsquire
Copy link
Member Author

jsquire commented Jul 9, 2024

depends on #708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
Status: Planned
Development

No branches or pull requests

1 participant