Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I prefer isExisting not be on the parameter list and is just set in the ctor with init #42422

Closed
JoshLove-msft opened this issue Mar 5, 2024 · 1 comment
Closed

I prefer isExisting not be on the parameter list and is just set in the ctor with init #42422

JoshLove-msft opened this issue Mar 5, 2024 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Provisioning

Comments

@JoshLove-msft
Copy link
Member 

          I prefer `isExisting` not be on the parameter list and is just set in the ctor with `init`

Originally posted by @m-nash in #42416 (comment)
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 5, 2024
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Provisioning and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 6, 2024
@tg-msft
Copy link
Member

tg-msft commented Sep 9, 2024

This has been changed to a static FromExisting like https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/provisioning/Azure.Provisioning.Storage/src/Generated/StorageAccount.cs#L551

@tg-msft tg-msft closed this as completed Sep 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Provisioning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jsquire @tg-msft @JoshLove-msft