Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClientModel: Investigate LRO pattern for unbranded clients #42114

Closed
pallavit opened this issue Feb 21, 2024 · 5 comments
Closed

ClientModel: Investigate LRO pattern for unbranded clients #42114

pallavit opened this issue Feb 21, 2024 · 5 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation System.ClientModel Base Core library
Milestone

Comments

@pallavit
Copy link
Contributor

pallavit commented Feb 21, 2024

This is not a GA blocker. We would like to get this in for the GA but we can unblock OpenAI SDK scenarios if this does not land on time.

Scope

  • Consider the OpenAI LRO pattern and other popular LRO patterns
  • Investigate whether a given pattern is generic and popular enough to include in System.ClientModel
  • For each LRO pattern that is adopted by Client Model, create an issue to track the work for implementation/testing.

Additional context

OpenAI uses LRO patterns for their assistance API. We will currently implement it in convenience layer and will in future consider supporting it in the de-branded toolchain end to end.

It is hard to envision today what this looks like as a generic LRO pattern that can be supported across clouds. Here is the typespec information about it - https://azure.github.io/typespec-azure/docs/libraries/azure-core/reference/js-api/interfaces/LroMetadata

@pallavit pallavit modified the milestones: Backlog, 2024-03 Feb 21, 2024
@jsquire
Copy link
Member

jsquire commented Feb 21, 2024

I thought that it was decided that LROs were an Azure pattern and any unbranded clients that needed them would be doing so in the client package. @KrzysztofCwalina, am I remembering that incorrectly?

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Feb 21, 2024
@pallavit
Copy link
Contributor Author

Unfortunately this is something we found recently and will be likely needed. We will need to understand the scope for March end release (we will get clarity by 2/27) but it is possible that this is something we need for it.

@pallavit pallavit changed the title Assistant APIs need LROs in Core Design non-Azure LRO patterns in debranded toolchain. Feb 22, 2024
@pallavit pallavit changed the title Design non-Azure LRO patterns in debranded toolchain. Design LRO patterns in debranded toolchain. Feb 22, 2024
@pallavit pallavit added the System.ClientModel Base Core library label Feb 22, 2024
@pallavit pallavit modified the milestones: 2024-03, Backlog Feb 22, 2024
@pallavit pallavit added the CodeGen Issues that relate to code generation label Feb 23, 2024
@annelo-msft annelo-msft modified the milestones: Backlog, 2024-04 Mar 12, 2024
@annelo-msft annelo-msft changed the title Design LRO patterns in debranded toolchain. ClientModel: Design LRO patterns in debranded toolchain. Mar 12, 2024
@jsquire
Copy link
Member

jsquire commented Mar 19, 2024

Rescoping this to "investigate" because we need to make a decision whether or not there's an LRO pattern popular enough that we feel it should be included in Client Model. If the OpenAI implementation is specific to OpenAI, then it should be local to that library.

@jsquire jsquire changed the title ClientModel: Design LRO patterns in debranded toolchain. ClientModel: Investigate LRO pattern inclusion for unbranded clients Mar 19, 2024
@jsquire jsquire changed the title ClientModel: Investigate LRO pattern inclusion for unbranded clients ClientModel: Investigate LRO pattern for unbranded clients Mar 19, 2024
@jsquire jsquire modified the milestones: 2024-04, 2024-05 Apr 30, 2024
@pallavit pallavit modified the milestones: 2024-05, 2024-06 May 9, 2024
@jsquire jsquire modified the milestones: 2024-06, 2024-07 Jun 19, 2024
@jsquire jsquire modified the milestones: 2024-07, 2024-08 Jul 23, 2024
@jsquire jsquire modified the milestones: 2024-08, 2024-09 Aug 15, 2024
@annelo-msft
Copy link
Member

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation System.ClientModel Base Core library
Projects
None yet
Development

No branches or pull requests

3 participants