[BUG] [Storage] DataLake Rename does not pass SAS from source to destination when appended on to the Source URL

[amnguye]

Library name and version

Azure.Storage.Files.DataLake 12.18.0-beta.1

Describe the bug

When using DataLakeFileClient.Rename(..) with a SAS on the URL of the Source File Client, and no SAS on the Destination Path, it will not use the source SAS.

Looks like this has been this way since version 12.12.0 of Azure.Storage.Files.DataLake.

Mitigation 1:
Create the Source Client with a AzureSasCredential.

Mitigation 2:
Pass the SAS on the destination
DataLakeFileClient destFile = await sasFileClient.RenameAsync(destinationPath: newPath + "?" + sourceSas);

Expected behavior

If source client is created with a SAS on the Uri, and then Rename is called, with the destination not having any SAS, the SAS should be passed to the destination.

Actual behavior

It will not pass the SAS to the destination.

Reproduction Steps

DataLakeSasQueryParameters sourceSas = GetNewDataLakeServiceSasCredentialsPath(fileSystemName, sourceDirectoryClient.Path, isDirectory: true);
DataLakeUriBuilder sourceUriBuilder = new DataLakeUriBuilder(sourceDirectoryClient.Uri)
{
    Sas = sourceSas
};

string destFileName = GetNewFileName();

DataLakeDirectoryClient sasDirectoryClient = InstrumentClient(new DataLakeDirectoryClient(sourceUriBuilder.ToUri(), GetOptions()));
DataLakeFileClient sasFileClient = InstrumentClient(sasDirectoryClient.GetFileClient(sourceFile.Name));

// Act
DataLakeFileClient destFile = await sasFileClient.RenameAsync(destinationPath: newPath);

Environment

n/a

[amnguye]

This was created from an offline customer issue.

[amnguye]

Let's check Share Files as well, since the same logic was used there.

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.