Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider adding fallback settlement on management link #37676

Closed
JoshLove-msft opened this issue Jul 17, 2023 · 0 comments · Fixed by #37704
Closed

Consider adding fallback settlement on management link #37676

JoshLove-msft opened this issue Jul 17, 2023 · 0 comments · Fixed by #37704
Assignees
@JoshLove-msft
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus

Comments

@JoshLove-msft
Copy link
Member 

          While testing this out, I noticed that there is an issue with how lock renewal works for non-session messages. Essentially, even if the connection drops and we reconnect, lock renewal continues to succeed. This is a problem because the settlement will ultimately still fail. We likely need some API support from the AMQP lib to peek into the unsettledMap on the AmqpLink.

Originally posted by @JoshLove-msft in #37643 (comment)
@JoshLove-msft JoshLove-msft self-assigned this Jul 17, 2023
@JoshLove-msft JoshLove-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 17, 2023
@github-actions github-actions bot added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 17, 2023
@jsquire jsquire removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jul 18, 2023
@JoshLove-msft JoshLove-msft mentioned this issue Jul 18, 2023
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshLove-msft JoshLove-msft

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fall back to management link when settling non-session message JoshLove-msft/azure-sdk-for-net
2 participants
@jsquire @JoshLove-msft