Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACR API Updates from Samples Review #34681

Closed
8 tasks done
annelo-msft opened this issue Mar 3, 2023 · 0 comments · Fixed by #34721
Closed
8 tasks done

ACR API Updates from Samples Review #34681

annelo-msft opened this issue Mar 3, 2023 · 0 comments · Fixed by #34721
Assignees
@annelo-msft
Labels
Client This issue points to a problem in the data-plane of the library. Container Registry

Comments

@annelo-msft
Copy link
Member

annelo-msft commented Mar 3, 2023 •
edited
Loading

Per review by @lmolkova:

  • Change OciManifest to OciImageManifest
  • Change name of sample (and related text) from Upload Artifact to Upload Image
  • Add BinaryData overload for both blob and manifest and update samples to use it
  • Change name of BlobDescriptor.Size to BlobDescriptor.SizeInBytes
  • Remove OciMediaType enum
  • Add a sample for upload/download of Docker manifest list to show use of custom manifest type
  • In custom download sample, show check of media type field to determine media type
  • Add array overload to download manifest to take multiple accept media types
@annelo-msft annelo-msft self-assigned this Mar 3, 2023
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 3, 2023
@annelo-msft annelo-msft added Container Registry Client This issue points to a problem in the data-plane of the library. labels Mar 3, 2023
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 3, 2023
@annelo-msft annelo-msft added this to the 2023-03 milestone Mar 3, 2023
This was referenced Mar 3, 2023
Closed
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@annelo-msft annelo-msft

Labels
Client This issue points to a problem in the data-plane of the library. Container Registry
Projects
Azure SDK for ACR
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates to ACR API and Samples for Consistency annelo-msft/azure-sdk-for-net
1 participant
@annelo-msft