Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage] [DataMovement] Remove unnecessary synchronization primitives (e.g. interlocked, semaphores) #33049

Closed
amnguye opened this issue Dec 14, 2022 · 0 comments · Fixed by #47020
Closed

[Storage] [DataMovement] Remove unnecessary synchronization primitives (e.g. interlocked, semaphores) #33049

amnguye opened this issue Dec 14, 2022 · 0 comments · Fixed by #47020
Assignees
@nickliu-msft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. pillar-performance The issue is related to performance, one of our core engineering pillars. Storage Storage Service (Queues, Blobs, Files)

Comments

@amnguye
Copy link
Member

amnguye commented Dec 14, 2022 •
edited by jalauzon-msft
Loading

Library name and version

Azure.Storage.DataMovement; Azure.Storage.DataMovement.Blobs

Query/Question

In the CommitChunkHandler, DownloadChunkHandler there are some unnecessary synchronization primitives (e.g. interlocked, semaphoreslim) which may not need and may be overkill to the purpose of preventing synchronization problems.

Let's analyze, remove and test to see which ones we need, to improve performance.

EDIT: Other places to consider:

Environment

No response
@amnguye amnguye added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. bug This issue requires a change to an existing behavior in the product in order to be resolved. labels Dec 14, 2022
@amnguye amnguye self-assigned this Dec 14, 2022
@amnguye amnguye mentioned this issue Dec 14, 2022
Merged
@jalauzon-msft jalauzon-msft added the pillar-performance The issue is related to performance, one of our core engineering pillars. label May 25, 2023
@amnguye amnguye assigned nickliu-msft and unassigned amnguye Sep 24, 2024
@nickliu-msft nickliu-msft mentioned this issue Nov 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickliu-msft nickliu-msft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. pillar-performance The issue is related to performance, one of our core engineering pillars. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
3 participants
@amnguye @jalauzon-msft @nickliu-msft