Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUERY] TableClient DeleteEntity using ITableEntity #32549

Closed
fhtino opened this issue Nov 18, 2022 · 4 comments · Fixed by #44986
Closed

[QUERY] TableClient DeleteEntity using ITableEntity #32549

fhtino opened this issue Nov 18, 2022 · 4 comments · Fixed by #44986
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables

Comments

@fhtino
Copy link

fhtino commented Nov 18, 2022

Library name and version

Azure.Data.Tables 12.7.0

Query/Question

TableClient.DeleteEntity accepts 2 parameters: partition key and row key.
Is there a reason why there is not an overload accepting an ITableEntity instance?
E.g. myclient.DeleteEntity(myEntity);

Environment

No response

@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 18, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. needs-team-triage Workflow: This issue needs the team to triage. Tables labels Nov 18, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Nov 18, 2022
@jsquire jsquire added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-team-triage Workflow: This issue needs the team to triage. labels Nov 18, 2022
@jsquire
Copy link
Member

jsquire commented Nov 18, 2022

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@christothes christothes added the feature-request This issue requires a new behavior in the product in order be resolved. label Nov 18, 2022
@JonathanCrd JonathanCrd self-assigned this Jun 13, 2024
@JonathanCrd
Copy link
Member

JonathanCrd commented Jun 17, 2024

Hi @fhtino, is there any scenario you are facing in which passing the whole entity would be more helpful than passing the properties?

For example, with the current method, you could use this:

myclient.DeleteEntity(myEntity.PartitionKey, myEntity.RowKey);

@christothes christothes added the needs-author-feedback Workflow: More information is needed from author to address the issue. label Jun 17, 2024
@github-actions github-actions bot removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Jun 17, 2024
Copy link

Hi @fhtino. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

@fhtino
Copy link
Author

fhtino commented Jun 20, 2024

@JonathanCrd there is no technical issue to pass partionkey and rowkey as separated items. In my opinion, a DeleteEntity accepting a ITableEntity item is more concise, clean and no risk of swapping rowkey with partitionkey.

E.g. myclient.DeleteEntity(myEntity);

@github-actions github-actions bot added needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team and removed needs-author-feedback Workflow: More information is needed from author to address the issue. labels Jun 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants