Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove compiler constants from Batch.csproj #3139

Closed
matthchr opened this issue Apr 28, 2017 · 4 comments
Closed

Remove compiler constants from Batch.csproj #3139

matthchr opened this issue Apr 28, 2017 · 4 comments
Assignees
@matthchr
Labels
Batch Service Attention Workflow: This issue is responsible by Azure service team.
Milestone
September 2017 Sp...

Comments

@matthchr
Copy link
Member

We have PORTABLE defined right now in Batch.csproj -- once AutoRest fixes this we can remove the IFDEF stuff.
@matthchr matthchr self-assigned this Apr 28, 2017
@matthchr matthchr mentioned this issue Apr 28, 2017
Merged
8 tasks
@shahabhijeet shahabhijeet added this to the May 2017 Sprint milestone May 12, 2017
@shahabhijeet
Copy link
Member

@matthchr what is the current status of this. Can we do this in Aug?

@matthchr
Copy link
Member Author

Sorry I missed this, was on vacation.

I will have to take a look, but I think that yes, we can probably remove this. I am not sure it will happen by the end of Aug though, maybe first week of Sept?

I'll take a look and if updating AutoRest version is really easy and just fixes it maybe I can sneak it in here before the end of the month...

@matthchr
Copy link
Member Author

I worked on this but got blocked by this: Azure/autorest#2558

@matthchr matthchr mentioned this issue Sep 8, 2017
Merged
8 tasks
@matthchr
Copy link
Member Author

This is fixed now

@bsiegel bsiegel added the Service Attention Workflow: This issue is responsible by Azure service team. label Sep 26, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@matthchr matthchr

Labels
Batch Service Attention Workflow: This issue is responsible by Azure service team.
Projects
None yet
Milestone
September 2017 Sprint
Development

No branches or pull requests
4 participants
@bsiegel @markcowl @matthchr @shahabhijeet