Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doc additions to DPG-generated methods #29277

Closed
heaths opened this issue Jun 13, 2022 · 3 comments
Closed

Allow doc additions to DPG-generated methods #29277

heaths opened this issue Jun 13, 2022 · 3 comments
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation DPG

Comments

@heaths
Copy link
Member

heaths commented Jun 13, 2022

For protocol methods like in PR #29144, we'd like to document that clients should always set the stringIndexType property to "Utf16CodePoint" for .NET strings. We can do this with models, but if they don't do it for .NET the string offset and length may not come back correctly.

It would be great if we could somehow add a <remarks> section, which the generator doesn't generate now (just summary, param, and exception sections). Off hand, I don't have any ideas. At worst, maybe an x-ms-remarks extension for autorest.csharp?

Even when we have models and default this for .NET - either with x-ms-client-default or like we did for the Question Answering HLC SDK - this would still be important for the protocol methods.

@heaths heaths added Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation DPG/RLC v1.0 labels Jun 13, 2022
@pallavit
Copy link
Contributor

pallavit commented Dec 19, 2023

@heaths do you still see value is doing this?

/cc: @lirenhe for triaging as appropriate.

@pallavit pallavit added the DPG label Dec 19, 2023
@heaths
Copy link
Member Author

heaths commented Jan 3, 2024

Yes, and I think we need a TypeSpec way to do this as well, though maybe client TSPs can accomplish that. @m-nash? For context, basically I want to be able - through client customizations or something - "attach" language-specific (or even generic, non-REST) docs without having to override the method just to add my own documentation.

Copy link

Hi @heaths, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 14, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. CodeGen Issues that relate to code generation DPG
Projects
None yet
Development

No branches or pull requests

3 participants