Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests to ensure the SDK does not contain classes with Resource or Collection suffix but not inheriting from ArmResource or ArmCollection #28948

Closed
ArcturusZhang opened this issue May 24, 2022 · 4 comments · Fixed by #38235
Closed

Add tests to ensure the SDK does not contain classes with Resource or Collection suffix but not inheriting from ArmResource or ArmCollection #28948

ArcturusZhang opened this issue May 24, 2022 · 4 comments · Fixed by #38235
Assignees
@HarveyLink
Labels
Azure.Core.TestFramework feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.

Comments

@ArcturusZhang
Copy link
Member

ArcturusZhang commented May 24, 2022 •
edited
Loading

We should be able to add some base test cases in the ManagementRecordedTestBase class
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 24, 2022
@azure-sdk
Copy link
Collaborator

Label prediction was below confidence level 0.6 for Model:ServiceLabels: 'ARM:0.37350348,Compute:0.06707574,Compute - VM:0.043491688'

@jsquire jsquire added Mgmt This issue is related to a management-plane library. Azure.Core.TestFramework labels May 24, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 24, 2022
@ArthurMa1978 ArthurMa1978 mentioned this issue Jun 14, 2022
Closed
@ArthurMa1978 ArthurMa1978 added the feature-request This issue requires a new behavior in the product in order be resolved. label Nov 17, 2022
@HarveyLink HarveyLink mentioned this issue Jul 25, 2023
Closed
@HarveyLink
Copy link
Member

#32587

@HarveyLink HarveyLink mentioned this issue Aug 16, 2023
Merged
@archerzz
Copy link
Member

archerzz commented Sep 5, 2023

Later on we can add this rule into analyzers, like https://github.com/archerzz/Azure.MgmtSdk.Analyzers/blob/main/Azure.MgmtSdk.Analyzers/ModelName/ModelNameResourceSuffixAnalyzer.cs

@archerzz
Copy link
Member

This can be reverted when we add the analyzer rules in Azure/azure-sdk-tools#6905

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarveyLink HarveyLink

Labels
Azure.Core.TestFramework feature-request This issue requires a new behavior in the product in order be resolved. Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Inherent Check for ArmResource and ArmCollection HarveyLink/azure-sdk-for-net
6 participants
@archerzz @jsquire @ArcturusZhang @ArthurMa1978 @HarveyLink @azure-sdk