Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] UsingPageBlobClient.GetManagedDiskPageRangesDiffAsync and AzurePageBlob.UploadPagesFromUriAsync don´t update blob with changes from new incremental snaphot #24959

Closed
agarciamiravet opened this issue Oct 27, 2021 · 7 comments
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)

Comments

@agarciamiravet
Copy link

Describe the bug
I´m triying to implement backup from managed disk to storages accounts, using incremental snapshots functionality.

Im using Github sample repo https://github.com/Azure-Samples/managed-disks-dotnet-backup-with-incremental-snapshots

My first issue creating first snapshot, blob is created but when I´m triying to create manage disk from this blob, I receive following error:

{
"status": "Failed",
"error": {
"code": "BadRequest",
"message": "The specified cookie value in VHD footer indicates that disk 'yourtargetbaseblobname.vhd' with blob https://alextextaa1.blob.core.windows.net:8443/vms/yourtargetbaseblobname.vhd is not a supported VHD. Disk is expected to have cookie value 'conectix'."
}
}

By these reason , I create blob with first snapshot from Powershell.

My second issue is:

When used sample code only for get Changes with GetManagedDiskPageRangesDiffAsync and copy incremental changes with UploadPagesFromUriAsync , I don´t received an error but when I create a virtual machine with new changes from the new snapshots, changes are not reflected and virtual machine run with First/base snapshot.

Expected behavior

Changes are reflected in blob , and when recreated managed disk and create a virtual machine these changes are reflected in virtual machine (Apps installed, created files i.e)

Actual behavior (include Exception or Stack Trace)
What is the actual behavior?

Using GetManagedDiskPageRangesDiffAsync and GetManagedDiskPageRangesDiffAsync from github sample https://github.com/Azure-Samples/managed-disks-dotnet-backup-with-incremental-snapshots don´t change blob correctly, because When i created manage disk from this snapshot changes, these changes are don´t exist.

To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

  1. Create a VM Windows Server 2019
  2. Create First incremental snaphot
  3. Copy first snapshot to blob in storage account using powershell, not code in sample repo because I received an error is not a supported VHD. Disk is expected to have cookie value 'conectix'.
  4. Create managed disk from blob storage with the first snapshot, and create VM. Its Ok and Virtual machine is OK
  5. Make changes to virtual machine, by example install apps and create files.
  6. Create my second snapshot, I test these snapshots creating a Managed disk and VM and Its ok apps installed and files changes are reflected in the new VM.
  7. Use repo code for copy changes between two snapshots, code no fails but when I created a new managed disk from blob with these changes and create a new VM , vm is ok and running but changes from the last snapshot and not reflected in code.

Environment:

  • Azure.Storage.Blobs 12.4.1
  • .Net Core 2.1
  • Visual Studio 2019 version 16.9.11
@ghost ghost added needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Oct 27, 2021
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. CXP Attention needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files) labels Oct 27, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 27, 2021
@ghost
Copy link

ghost commented Oct 27, 2021

Thank you for your feedback. This has been routed to the support team for assistance.

@SaurabhSharma-MSFT
Copy link
Member

SaurabhSharma-MSFT commented Oct 28, 2021

@agarciamiravet Regarding your Issue 1), I have tried using the shared GitHub repo sample and I am able to create snapshot without any issues.
image

@SaurabhSharma-MSFT SaurabhSharma-MSFT self-assigned this Oct 28, 2021
@SaurabhSharma-MSFT
Copy link
Member

SaurabhSharma-MSFT commented Oct 28, 2021

@agarciamiravet I have tested it further and I am facing same error as yours while creating managed disk from the blob snapshot.
image

Looks like some issue with sample repo so routing this to appropriate team to look into.

@SaurabhSharma-MSFT SaurabhSharma-MSFT added Service Attention Workflow: This issue is responsible by Azure service team. and removed CXP Attention labels Oct 28, 2021
@ghost
Copy link

ghost commented Oct 28, 2021

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

Issue Details

Describe the bug
I´m triying to implement backup from managed disk to storages accounts, using incremental snapshots functionality.

Im using Github sample repo https://github.com/Azure-Samples/managed-disks-dotnet-backup-with-incremental-snapshots

My first issue creating first snapshot, blob is created but when I´m triying to create manage disk from this blob, I receive following error:

{
"status": "Failed",
"error": {
"code": "BadRequest",
"message": "The specified cookie value in VHD footer indicates that disk 'yourtargetbaseblobname.vhd' with blob https://alextextaa1.blob.core.windows.net:8443/vms/yourtargetbaseblobname.vhd is not a supported VHD. Disk is expected to have cookie value 'conectix'."
}
}

By these reason , I create blob with first snapshot from Powershell.

My second issue is:

When used sample code only for get Changes with GetManagedDiskPageRangesDiffAsync and copy incremental changes with UploadPagesFromUriAsync , I don´t received an error but when I create a virtual machine with new changes from the new snapshots, changes are not reflected and virtual machine run with First/base snapshot.

Expected behavior

Changes are reflected in blob , and when recreated managed disk and create a virtual machine these changes are reflected in virtual machine (Apps installed, created files i.e)

Actual behavior (include Exception or Stack Trace)
What is the actual behavior?

Using GetManagedDiskPageRangesDiffAsync and GetManagedDiskPageRangesDiffAsync from github sample https://github.com/Azure-Samples/managed-disks-dotnet-backup-with-incremental-snapshots don´t change blob correctly, because When i created manage disk from this snapshot changes, these changes are don´t exist.

To Reproduce
Steps to reproduce the behavior (include a code snippet, screenshot, or any additional information that might help us reproduce the issue)

  1. Create a VM Windows Server 2019
  2. Create First incremental snaphot
  3. Copy first snapshot to blob in storage account using powershell, not code in sample repo because I received an error is not a supported VHD. Disk is expected to have cookie value 'conectix'.
  4. Create managed disk from blob storage with the first snapshot, and create VM. Its Ok and Virtual machine is OK
  5. Make changes to virtual machine, by example install apps and create files.
  6. Create my second snapshot, I test these snapshots creating a Managed disk and VM and Its ok apps installed and files changes are reflected in the new VM.
  7. Use repo code for copy changes between two snapshots, code no fails but when I created a new managed disk from blob with these changes and create a new VM , vm is ok and running but changes from the last snapshot and not reflected in code.

Environment:

  • Azure.Storage.Blobs 12.4.1
  • .Net Core 2.1
  • Visual Studio 2019 version 16.9.11
Author: agarciamiravet
Assignees: SaurabhSharma-MSFT
Labels:

Storage, Service Attention, Client, customer-reported, question, needs-team-attention

Milestone: -

@agarciamiravet
Copy link
Author

Hi everybody.

Any news about these issue?

Thanks in advance.

@amishra-dev amishra-dev added bug This issue requires a change to an existing behavior in the product in order to be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Nov 30, 2021
@amishra-dev
Copy link
Contributor

Hi @agarciamiravet (Alejandro),
My friends from the service are telling me that this issue is related to a service bug whose fix is rolling out. As a workaround can you follow the steps laid out in #23031 (comment)

You can make the change here: https://github.com/Azure-Samples/managed-disks-dotnet-backup-with-incremental-snapshots/blob/05c0049b9830c8e231727f37425babd20a80ee7c/CopyManagedDisksIncrementalSnapshots/Program.cs#L168

@amishra-dev
Copy link
Contributor

please file a new issue if you are still hitting this, ideally the rollout should have taken care of this.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team Service Attention Workflow: This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

4 participants