-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create unified story for samples in our repo #24070
Comments
@heaths I believe we unified our story with testable samples, do you still see discrepancy in the newer SDKs? If so could you please share what the unified experience would look like? |
I helped drive testable samples in the first place. :) This is actually different. Only SDK-specific samples get the benefits of stuff under That said, unless @jsquire - who has also been involved in various discussions of this nature - has any strong desire that we should invest in this area, this has been open for a couple years and we still haven't acted on it, so I agree it's probably not high-priority. |
@heaths: I'm good with closing this out. The patterns from KeyVault have also been used by packages in the messaging ecosystem and the overall patterns for enabling in-repo and stand-alone use have held up well. |
We have a number of different ways of doing samples in Azure/azure-sdk-for-net, as seen in
/samples
,/sdk/keyvault/samples
, and some SDKs' individualsamples
directory. The/samples
directory is effectively outside the scope of most of what/eng/*.{props,targets}
files do, but we still want:/sdk/keyvault/samples/sharelink
but it's incredibly hacky.Basically, it would be ideal if we can get some of the benefits like analyzers and test infrastructure without the assertions like even specifying our own
PackageReference/@Version
attribute, which customers downloading sample code would need (our@OverrideVersion
will not be effective).The text was updated successfully, but these errors were encountered: