Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machinelearningservices - cspell found spelling errors in public API surface #23181

Closed
danieljurek opened this issue Aug 6, 2021 · 3 comments
Closed

machinelearningservices - cspell found spelling errors in public API surface #23181

danieljurek opened this issue Aug 6, 2021 · 3 comments
Assignees
@HarveyLink
Labels
Machine Learning Mgmt This issue is related to a management-plane library.
Milestone
Backlog

Comments

@danieljurek
Copy link
Member

danieljurek commented Aug 6, 2021 •
edited
Loading

Investigation for this PR: #23150 found spelling errors. When the linked PR merges this service will be opted out of public API surface spell checking to keep other PRs unblocked. This issue describes how to opt back in.

If the above linked PR has not merged this service is still opted out and not blocked by the detection of spelling errors in the public API surface.

What to do

  1. Correct spelling errors or check in fixes for the false positives
  2. Opt back into Public API surafe spell checking

Correct errors

To correct false positives or learn about spell checking see: https://aka.ms/azsdk/engsys/spellcheck

Spell Check Output

1/1 .\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs 1257.55ms X
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:6:110 - Unknown word (Skus)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:7:115 - Unknown word (Skus)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:430:23 - Unknown word (Cname)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:457:23 - Unknown word (Cname)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:498:28 - Unknown word (Kube)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:500:27 - Unknown word (Kube)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1065:89 - Unknown word (Gluster)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1246:69 - Unknown word (Gluster)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1246:86 - Unknown word (Gluster)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1305:91 - Unknown word (Grpc)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1498:23 - Unknown word (Conda)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:1586:26 - Unknown word (Gluster)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2003:27 - Unknown word (Conda)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2004:23 - Unknown word (Conda)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2101:90 - Unknown word (Reimage)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2124:92 - Unknown word (Reimage)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2507:116 - Unknown word (Cran)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2510:23 - Unknown word (Rscript)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2519:116 - Unknown word (Cran)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2522:23 - Unknown word (Rscript)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2623:23 - Unknown word (Cname)
D:\code\azure-sdk-for-net\sdk\machinelearningservices\Azure.ResourceManager.MachineLearningServices\api\Azure.ResourceManager.MachineLearningServices.netstandard2.0.cs:2889:21 - Unknown word (VCPUs)
CSpell: Files checked: 1, Issues found: 22 in 1 files

To check the public API surface locally, in the root of the repo run:

eng/scripts/Export-API.ps1 -ServiceDirectory machinelearningservices -SpellCheckPublicApiSurface

You may also need to set -SDKType if the appropriate value of SDKType is not all for the service.

Opt back in

NEW INSTRUCTIONS: In the .vscode/cspell.json file remove the line for your service (of the form "sdk/<service>/*/api/*.cs") from the ignorePaths section and check in the change.

OLD INSTRUCTIONS: In the ci.yml file for this service, remove the line: SpellCheckPublicApiSurface: false
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 6, 2021
@jsquire jsquire added Machine Learning Mgmt This issue is related to a management-plane library. labels Aug 7, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 7, 2021
@yungezz
Copy link
Member

yungezz commented Aug 23, 2021

same issue with #23188

@yungezz yungezz assigned ArcturusZhang and unassigned allenjzhang Aug 24, 2021
@ArcturusZhang
Copy link
Member

Adding @HarveyLink for awareness since he is recently working on ML new track 2 SDK

@ArthurMa1978 ArthurMa1978 added this to the [2021] November milestone Oct 21, 2021
@jsquire jsquire modified the milestones: [2022] January, Backlog Jan 18, 2022
@ArcturusZhang ArcturusZhang removed their assignment Jan 26, 2022
@mcgallan
Copy link
Member

The Pull request successfully merged and closed

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarveyLink HarveyLink

Labels
Machine Learning Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
9 participants
@jsquire @danieljurek @allenjzhang @ArcturusZhang @ArthurMa1978 @HarveyLink @yungezz @v-strudm-msft @mcgallan