Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAS and other blob sanitization rules to the base framework #19316

Closed
pakrym opened this issue Mar 8, 2021 · 5 comments
Closed

Add SAS and other blob sanitization rules to the base framework #19316

pakrym opened this issue Mar 8, 2021 · 5 comments
Assignees
Labels
Azure.Core.TestFramework Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@pakrym
Copy link
Contributor

pakrym commented Mar 8, 2021

Other services use storage and don't know they need to add sanitization rules.

@pakrym pakrym added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. Azure.Core labels Mar 8, 2021
@weshaggard
Copy link
Member

We should see if there is a way to plugin the credscan detection library into the framework to try and sanitize all the text in the recording files.

@pakrym
Copy link
Contributor Author

pakrym commented Mar 15, 2021

We should consider sanitizing bodies too or adding a post-recording check that would throw if SAS signature is found.

@JoshLove-msft
Copy link
Member

@weshaggard can you provide more details on the credscan library that we use?

@pakrym
Copy link
Contributor Author

pakrym commented Jan 25, 2022

Azure/azure-sdk-tools#1950 should handle this.

@JoshLove-msft
Copy link
Member

Closing as this will be tracked by the linked Test Proxy issue - Azure/azure-sdk-tools#1950

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core.TestFramework Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

No branches or pull requests

3 participants