[QUERY] ServiceBusRetryPolicy anonymous class allocation

[danielmarbach]

I've looked at the usage of ServiceBusRetryPolicy.RunOperation and creates a lot of display class allocations. By providing overloads of RunOperation like

        internal async Task<TResult> RunOperation<T1, T2, T3, TResult>(
            Func<T1, T2, T3, TimeSpan, CancellationToken, Task<TResult>> operation,
            TransportConnectionScope scope,
            T1 t1,
            T2 t2,
            T3 t3,
            CancellationToken cancellationToken)
        {

it would be possible to get rid of those. Example

            this.\u003C\u003E8__1 = new AmqpReceiver.\u003C\u003Ec__DisplayClass34_0();
            this.\u003C\u003E8__1.\u003C\u003E4__this = this.\u003C\u003E4__this;
            this.\u003C\u003E8__1.maxMessages = this.maxMessages;
            this.\u003C\u003E8__1.maxWaitTime = this.maxWaitTime;
            this.\u003C\u003E8__1.cancellationToken = this.cancellationToken;
            this.\u003C\u003E8__1.messages = (IReadOnlyList<ServiceBusReceivedMessage>) null;
            // ISSUE: method pointer
            awaiter = amqpReceiver._retryPolicy.RunOperation(new Func<TimeSpan, Task>((object) this.\u003C\u003E8__1, __methodptr(\u003CReceiveMessagesAsync\u003Eb__0)), (TransportConnectionScope) amqpReceiver._connectionScope, this.\u003C\u003E8__1.cancellationToken).ConfigureAwait(false).GetAwaiter();
            if (!awaiter.IsCompleted)
            {
              this.\u003C\u003E1__state = num2 = 0;
              this.\u003C\u003Eu__1 = awaiter;
              this.\u003C\u003Et__builder.AwaitUnsafeOnCompleted<ConfiguredTaskAwaitable.ConfiguredTaskAwaiter, AmqpReceiver.\u003CReceiveMessagesAsync\u003Ed__34>(ref awaiter, ref this);
              return;
            }

vs

          ConfiguredTaskAwaitable<IReadOnlyList<ServiceBusReceivedMessage>>.ConfiguredTaskAwaiter awaiter;
          int num2;
          if (num1 != 0)
          {
            // ISSUE: method pointer
            awaiter = amqpReceiver._retryPolicy.RunOperation2<int, TimeSpan?, IReadOnlyList<ServiceBusReceivedMessage>>(new Func<TimeSpan, int, TimeSpan?, CancellationToken, Task<IReadOnlyList<ServiceBusReceivedMessage>>>((object) amqpReceiver, __methodptr(\u003CReceiveMessagesAsync\u003Eb__34_0)), (TransportConnectionScope) amqpReceiver._connectionScope, this.maxMessages, this.maxWaitTime, this.cancellationToken).ConfigureAwait(false).GetAwaiter();
            if (!awaiter.IsCompleted)
            {
              this.\u003C\u003E1__state = num2 = 0;
              this.\u003C\u003Eu__1 = awaiter;
              this.\u003C\u003Et__builder.AwaitUnsafeOnCompleted<ConfiguredTaskAwaitable<IReadOnlyList<ServiceBusReceivedMessage>>.ConfiguredTaskAwaiter, AmqpReceiver.\u003CReceiveMessagesAsync\u003Ed__34>(ref awaiter, ref this);
              return;
            }

is that something worth pursuing or not worth the complexity?

There would still be a Func allocation though.

[jsquire]

Hi @danielmarbach. Thanks for your feedback and the suggestion. I think there's merit to looking into this as an optimization. Looping Josh in for his thoughts.

[JoshLove-msft]

Sure, as long it still all funnels through one core method (and the tests still pass 😄). Thanks @danielmarbach!

[danielmarbach]

Fingers crossed ;) #19522