Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Remove unnecessary ClientOptions type #16369

Closed
kinelski opened this issue Oct 28, 2020 · 0 comments · Fixed by #16436
Closed

[MetricsAdvisor] Remove unnecessary ClientOptions type #16369

kinelski opened this issue Oct 28, 2020 · 0 comments · Fixed by #16436
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2020] November

Comments

@kinelski
Copy link
Member

We currently have:

  • Metrics Advisor Client Options
  • Metrics Advisor Administration Client Options

These were defined separately for both of our clients, but the service does not differentiate between admin/other operations. We can merge them into the same type: MetricsAdvisorClientsOptions.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Metrics Advisor labels Oct 28, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 28, 2020
@kinelski kinelski self-assigned this Oct 28, 2020
@kinelski kinelski mentioned this issue Oct 29, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Remove unnecessary ClientOptions type kinelski/azure-sdk-for-net
1 participant
@kinelski