Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQ]Azure.Identity should expose trace from MSAL library #14450

Closed
erich-wang opened this issue Aug 21, 2020 · 2 comments · Fixed by #19637
Closed

[FEATURE REQ]Azure.Identity should expose trace from MSAL library #14450

erich-wang opened this issue Aug 21, 2020 · 2 comments · Fixed by #19637
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Milestone
Backlog

Comments

@erich-wang
Copy link
Member

Library or service name.
What library or service is this request related to?
Azure.Identity

Is your feature request related to a problem? Please describe.
What feature would you like to get added? What problem is it solving?

MSAL library allows customers to enable MSAL related traces by using PublicClientApplicationBuilder.WithLogging(...), Azure.Identity should expose such trace functionality.

(False) MSAL 4.16.1.0 MSAL.NetCore Microsoft Windows 10.0.19041 [08/21/2020 03:24:12 - 9eff121e-7beb-44fc-883b-4bebcff84296] Resolving authority endpoints... Already resolved? - FALSE
(False) MSAL 4.16.1.0 MSAL.NetCore Microsoft Windows 10.0.19041 [08/21/2020 03:28:41 - 9eff121e-7beb-44fc-883b-4bebcff84296] Exception type: Microsoft.Identity.Client.MsalServiceException
, ErrorCode: authorization_pending
HTTP StatusCode 400
CorrelationId 9eff121e-7beb-44fc-883b-4bebcff84296
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 21, 2020
@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. KeyVault needs-team-triage Workflow: This issue needs the team to triage. labels Aug 21, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Aug 21, 2020
@AlexGhiondea AlexGhiondea added Azure.Identity question The issue doesn't require a change to the product in order to be resolved. Most issues start as that and removed KeyVault needs-team-triage Workflow: This issue needs the team to triage. labels Aug 21, 2020
@AlexGhiondea
Copy link
Contributor

@schaabs can you take a look at this?

@AlexanderSher AlexanderSher added this to the [2020] October milestone Aug 25, 2020
@schaabs schaabs modified the milestones: [2020] October, Backlog Oct 13, 2020
@schaabs schaabs removed their assignment Oct 13, 2020
@ayeltsov
Copy link

Came here today to log this same issue.

I was considering migrating portion of the code off direct MSAL calls to higher level Azure.Identity, but found that it hides MSAL logging

@christothes christothes added feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 19, 2021
@christothes christothes mentioned this issue Mar 23, 2021
Merged
@christothes christothes mentioned this issue Apr 6, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Enable MSAL logging christothes/azure-sdk-for-net
7 participants
@jsquire @christothes @AlexGhiondea @AlexanderSher @ayeltsov @schaabs @erich-wang