Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[text analytics] update readme #12472

Closed
1 of 2 tasks
iscai-msft opened this issue Jun 3, 2020 · 2 comments · Fixed by #12541
Closed
1 of 2 tasks

[text analytics] update readme #12472

iscai-msft opened this issue Jun 3, 2020 · 2 comments · Fixed by #12541
Assignees
@maririos
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive Services
Milestone
[2020] June

Comments

@iscai-msft
Copy link

iscai-msft commented Jun 3, 2020 •
edited by maririos
Loading

  • Consider adding a key concept on DocumentErrorHandling (python's is here, but .net's would tell the user to check the .errors of batch)
  • Make sample links in readme absolute, not relative. This is potentially causing problems when being uploaded to docs.microsoft.com

cc @czubair
@maririos
Copy link
Member

maririos commented Jun 3, 2020

Thank you so much Izzy!

@maririos maririos added this to the [2020] June milestone Jun 3, 2020
@maririos maririos added blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive Services TextAnalytics labels Jun 3, 2020
@maririos
Copy link
Member

maririos commented Jun 5, 2020

Consider adding a key concept on DocumentErrorHandling (python's is here, but .net's would tell the user to check the .errors of batch)

Because errors work different if it is a single vs batch method, we included the error information in the later. https://github.com/Azure/azure-sdk-for-net/tree/master/sdk/textanalytics/Azure.AI.TextAnalytics#return-value-collection

@maririos maririos mentioned this issue Jun 5, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maririos maririos

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics Cognitive Services
Projects
None yet
Milestone
[2020] June
Development

Successfully merging a pull request may close this issue.

[TA] Drop preview and change readme links to absolute maririos/azure-sdk-for-net
5 participants
@kinelski @AlexGhiondea @maririos @annelo-msft @iscai-msft