Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure.Search: Fix IndexDocuments merge with static documents test from Track 1 #10602

Closed
tg-msft opened this issue Mar 13, 2020 · 7 comments
Closed

Azure.Search: Fix IndexDocuments merge with static documents test from Track 1 #10602

tg-msft opened this issue Mar 13, 2020 · 7 comments
Assignees
@tg-msft @ShivangiReja
Labels
Client This issue points to a problem in the data-plane of the library. Search
Milestone
Backlog

Comments

@tg-msft
Copy link
Member

tg-msft commented Mar 13, 2020

This is the only disabled test from the Track 1 suite relative to Preview 1 features.
@tg-msft tg-msft added Client This issue points to a problem in the data-plane of the library. Search labels Mar 13, 2020
@tg-msft tg-msft self-assigned this Mar 13, 2020
@tg-msft tg-msft added this to the [2020] April milestone Mar 19, 2020
@tg-msft
Copy link
Member Author

tg-msft commented Mar 19, 2020

https://github.com/Azure/azure-sdk-for-net/blob/master/sdk/search/Microsoft.Azure.Search/tests/Tests/IndexingTests.cs#L846

@tg-msft
Copy link
Member Author

tg-msft commented Mar 19, 2020

Track 1 isn't serializing nulls to the wire based on serializer settings. We can revisit this once we add that level of serialization option customization in Track 2.

@tg-msft tg-msft modified the milestones: [2020] April, [2020] May Apr 6, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Apr 8, 2020
Closed
26 tasks
@tg-msft tg-msft modified the milestones: [2020] May, [2020] June May 8, 2020
@AlexGhiondea AlexGhiondea mentioned this issue May 8, 2020
Closed
17 tasks
@tg-msft tg-msft modified the milestones: [2020] June, [2020] July Jun 9, 2020
@AlexGhiondea AlexGhiondea mentioned this issue Jun 11, 2020
Closed
15 tasks
@tg-msft tg-msft modified the milestones: [2020] November, MQ-2020 Nov 18, 2020
@jsquire jsquire modified the milestones: MQ-2020, Backlog Jan 13, 2021
@AlexGhiondea
Copy link
Contributor

@tg-msft can this be closed now?

@tg-msft
Copy link
Member Author

tg-msft commented Jun 9, 2021

No, we've still got a bunch of commented out Track 1 tests that were never fixed after we started properly supporting ObjectSerializer.

@pallavit
Copy link
Contributor

@tg-msft can this be closed now considering track1 SDK has been deprecated.

@tg-msft
Copy link
Member Author

tg-msft commented Jun 16, 2022

No, this is about adding Track 1 test cases to Track 2. See https://github.com/Azure/azure-sdk-for-net/blob/main/sdk/search/Azure.Search.Documents/tests/DocumentOperations/IndexingTests.cs#L1014

@pallavit
Copy link
Contributor

@ShivangiReja I am closing this issue as not planned given our priorities, feel free to reopen if you feel otherwise.
/cc: @tg-msft as FYI

@pallavit pallavit closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tg-msft tg-msft

@ShivangiReja ShivangiReja

Labels
Client This issue points to a problem in the data-plane of the library. Search
Projects
Azure SDK for Search
Archived in project
Milestone
Backlog
Development

No branches or pull requests
5 participants
@jsquire @tg-msft @AlexGhiondea @pallavit @ShivangiReja