From c2467b2df31128d2b7578eb5e7b5a74f165a7b24 Mon Sep 17 00:00:00 2001 From: Anne Thompson Date: Thu, 16 Feb 2023 17:33:29 -0800 Subject: [PATCH] Add comments for tricky tests. --- .../tests/DynamicJsonTests.cs | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/sdk/core/Azure.Core.Experimental/tests/DynamicJsonTests.cs b/sdk/core/Azure.Core.Experimental/tests/DynamicJsonTests.cs index 655832510d4c..1b5ada82cb93 100644 --- a/sdk/core/Azure.Core.Experimental/tests/DynamicJsonTests.cs +++ b/sdk/core/Azure.Core.Experimental/tests/DynamicJsonTests.cs @@ -556,6 +556,7 @@ public void CanSetCamelCasePascalGetters() Assert.AreEqual(3, (int)dynamicJson.bar); Assert.AreEqual(3, (int)dynamicJson.Bar); + // PascalCase getters find camelCase properties and sets them. dynamicJson.Foo = 4; dynamicJson.Bar = 5; @@ -588,6 +589,7 @@ public void CanSetCamelCasePascalGettersCamelSetters() Assert.AreEqual(3, (int)dynamicJson.bar); Assert.AreEqual(3, (int)dynamicJson.Bar); + // PascalCase getters find camelCase properties and sets them. dynamicJson.Foo = 4; dynamicJson.Bar = 5; @@ -613,7 +615,7 @@ public void CanSetPascalCaseNoMapping() }; dynamic dynamicJson = new BinaryData(json).ToDynamic(options); - // Existing property access + // This adds a new property, since it doesn't find `Foo`. dynamicJson.foo = 2; // New property access @@ -624,7 +626,10 @@ public void CanSetPascalCaseNoMapping() Assert.AreEqual(3, (int)dynamicJson.bar); Assert.AreEqual(null, dynamicJson.Bar); + // This updates the PascalCase property and not the camelCase one. dynamicJson.Foo = 4; + + // This creates a new PascalCase property. dynamicJson.Bar = 5; Assert.AreEqual(2, (int)dynamicJson.foo); @@ -655,9 +660,10 @@ public void CanSetPascalCasePascalGetters() Assert.AreEqual(3, (int)dynamicJson.bar); Assert.AreEqual(3, (int)dynamicJson.Bar); + // This updates the PascalCase property and not the camelCase one. dynamicJson.Foo = 4; - // This property exists now as `bar`, so it updates the camelCase property. + // The PascalCase getter finds `bar`, so it updates the camelCase property. dynamicJson.Bar = 5; // New property is created as PascalCase @@ -678,7 +684,7 @@ public void CanSetPascalCasePascalGettersCamelSetters() dynamic dynamicJson = new BinaryData(json).ToDynamic(); - // Existing property access + // Existing property access does not add a camelCase property. dynamicJson.Foo = 2; // New property is created as camelCase