From 46eb5f19abcbd9eff856be2a009b3722be6d4679 Mon Sep 17 00:00:00 2001
From: Heath Stewart <heaths@microsoft.com>
Date: Thu, 19 Nov 2020 14:26:04 -0800
Subject: [PATCH] Disable code coverage of track 2 mgmt

Opened #17090 to track re-enabling once improved.
---
 eng/CodeCoverage.targets                              | 4 +++-
 eng/Directory.Build.Data.targets                      | 2 +-
 eng/pipelines/templates/jobs/archetype-sdk-client.yml | 6 +++---
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/eng/CodeCoverage.targets b/eng/CodeCoverage.targets
index f38947af3980..e2ca1fc85b30 100644
--- a/eng/CodeCoverage.targets
+++ b/eng/CodeCoverage.targets
@@ -34,7 +34,9 @@
       <CoverageReportCommandLine>$(CoverageReportCommandLine) "-filefilters:+$(CodeCoverageDirectory)\**"</CoverageReportCommandLine>
     </PropertyGroup>
     <Exec Command="$(CoverageReportCommandLine)"
-          IgnoreExitCode="true" />
+          IgnoreExitCode="true"
+          StandardErrorImportance="high"
+          StandardOutputImportance="low" />
   </Target>
 
   <!--
diff --git a/eng/Directory.Build.Data.targets b/eng/Directory.Build.Data.targets
index b08f22e03cc1..b2f19bf03eab 100644
--- a/eng/Directory.Build.Data.targets
+++ b/eng/Directory.Build.Data.targets
@@ -77,7 +77,7 @@
     and likely easier to remember than the VSTest platform integration.
     Also: https://github.com/coverlet-coverage/coverlet/blob/master/Documentation/KnownIssues.md#1-vstest-stops-process-execution-earlydotnet-test
   -->
-  <PropertyGroup Condition="'$(CollectCoverage)' == 'true' and '$(IsClientLibrary)' == 'true' and '$(IsTestProject)' == 'true' and '$(ExcludeFromCodeCoverage)' != 'true'">
+  <PropertyGroup Condition="'$(CollectCoverage)' == 'true' and '$(IsClientLibrary)' == 'true' and '$(IsTestProject)' == 'true' and '$(IsMgmtClientLibrary)' != 'true' and '$(ExcludeFromCodeCoverage)' != 'true'">
     <_ImportCodeCoverage>true</_ImportCodeCoverage>
     <VSTestCollect Condition="'$(VSTestCollect)' == ''">XPlat Code Coverage</VSTestCollect>
     <!-- Override this property in your projects' or solutions' Directory.Build.props to further customize code coverage. -->
diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml
index fec7ea24ce7a..91fd2b0bd3e8 100644
--- a/eng/pipelines/templates/jobs/archetype-sdk-client.yml
+++ b/eng/pipelines/templates/jobs/archetype-sdk-client.yml
@@ -110,8 +110,8 @@ jobs:
     condition: and(succeededOrFailed(), ne(variables['Skip.Test'], true))
     variables:
       - template: ../variables/globals.yml
-      - name: disable.coverage.autogenerate
-        value: true
+      # - name: disable.coverage.autogenerate
+      #   value: true
     strategy:
       maxParallel: $[ variables['MaxParallelTestJobs'] ]
       matrix:
@@ -169,7 +169,7 @@ jobs:
         inputs:
           reports: $(Build.SourcesDirectory)\sdk\${{parameters.ServiceDirectory}}\**\coverage.cobertura.xml
           targetdir: $(Build.SourcesDirectory)
-          reporttypes: Cobertura;HtmlSummary
+          reporttypes: Cobertura
           filefilters: +$(Build.SourcesDirectory)\sdk\${{parameters.ServiceDirectory}}\**
           verbosity: Verbose
       - task: PublishCodeCoverageResults@1