From 5534ddab20bda68210ded1f0fd1b2b624191e622 Mon Sep 17 00:00:00 2001 From: Malcolm Tyrrell Date: Wed, 10 Nov 2021 14:48:21 +0000 Subject: [PATCH 1/4] Changes for identity 2.0.1 --- .../mixed-reality-remote-rendering/package.json | 2 +- .../samples-dev/moreComplexConversion.ts | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/sdk/remoterendering/mixed-reality-remote-rendering/package.json b/sdk/remoterendering/mixed-reality-remote-rendering/package.json index a9527bfa9c60..7e1a08ed50e3 100644 --- a/sdk/remoterendering/mixed-reality-remote-rendering/package.json +++ b/sdk/remoterendering/mixed-reality-remote-rendering/package.json @@ -88,7 +88,7 @@ "devDependencies": { "@azure/dev-tool": "^1.0.0", "@azure/eslint-plugin-azure-sdk": "^3.0.0", - "@azure/identity": "^1.1.0", + "@azure/identity": "^2.0.1", "@azure-tools/test-recorder": "^1.0.0", "@microsoft/api-extractor": "^7.18.11", "@types/chai": "^4.1.6", diff --git a/sdk/remoterendering/mixed-reality-remote-rendering/samples-dev/moreComplexConversion.ts b/sdk/remoterendering/mixed-reality-remote-rendering/samples-dev/moreComplexConversion.ts index 921fa4e32ef9..f3a75431ec2f 100644 --- a/sdk/remoterendering/mixed-reality-remote-rendering/samples-dev/moreComplexConversion.ts +++ b/sdk/remoterendering/mixed-reality-remote-rendering/samples-dev/moreComplexConversion.ts @@ -67,12 +67,15 @@ export function getClientWithAAD() { } export function getClientWithDeviceCode() { - const deviceCodeCallback = (deviceCodeInfo: DeviceCodeInfo) => { + const userPromptCallback = (deviceCodeInfo: DeviceCodeInfo) => { console.debug(deviceCodeInfo.message); console.log(deviceCodeInfo.message); }; - const credential = new DeviceCodeCredential(tenantId, clientId, deviceCodeCallback, { + const credential = new DeviceCodeCredential({ + tenantId: tenantId, + clientId: clientId, + userPromptCallback: userPromptCallback, authorityHost: "https://login.microsoftonline.com/" + tenantId }); From df0fc1fbf0214e22e2d445b164b7f517db2c17eb Mon Sep 17 00:00:00 2001 From: Malcolm Tyrrell Date: Wed, 10 Nov 2021 15:01:33 +0000 Subject: [PATCH 2/4] Change README to match --- .../mixed-reality-remote-rendering/README.md | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/sdk/remoterendering/mixed-reality-remote-rendering/README.md b/sdk/remoterendering/mixed-reality-remote-rendering/README.md index f51d937ccece..0c2ef5fa0aa7 100644 --- a/sdk/remoterendering/mixed-reality-remote-rendering/README.md +++ b/sdk/remoterendering/mixed-reality-remote-rendering/README.md @@ -97,12 +97,15 @@ const client = new RemoteRenderingClient(serviceEndpoint, accountId, accountDoma Use the `DeviceCodeCredential` object to perform device code authentication. ```typescript Snippet:CreateAClientWithDeviceCode -let deviceCodeCallback = (deviceCodeInfo: DeviceCodeInfo) => { +const userPromptCallback = (deviceCodeInfo: DeviceCodeInfo) => { console.debug(deviceCodeInfo.message); console.log(deviceCodeInfo.message); }; -let credential = new DeviceCodeCredential(tenantId, clientId, deviceCodeCallback, { +const credential = new DeviceCodeCredential({ + tenantId: tenantId, + clientId: clientId, + userPromptCallback: userPromptCallback, authorityHost: "https://login.microsoftonline.com/" + tenantId }); From ecf0b6d527000edee16b9e1f091e3204e06c88e3 Mon Sep 17 00:00:00 2001 From: Malcolm Tyrrell Date: Thu, 11 Nov 2021 16:32:02 +0000 Subject: [PATCH 3/4] Update changelog --- .../mixed-reality-remote-rendering/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md b/sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md index b6403bf6c954..a94ca3caccb5 100644 --- a/sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md +++ b/sdk/remoterendering/mixed-reality-remote-rendering/CHANGELOG.md @@ -1,5 +1,9 @@ # Release History +## 1.0.0-beta.2 (Unreleased) + +- Update samples to depend on Azure Identity 2.0.1. + ## 1.0.0-beta.1 (2021-09-21) - Initial release. From a3eda4a097d988e7fe322d2d1ef70a742d218011 Mon Sep 17 00:00:00 2001 From: Malcolm Tyrrell Date: Mon, 15 Nov 2021 11:27:53 +0000 Subject: [PATCH 4/4] Changes to pnpm-lock file --- common/config/rush/pnpm-lock.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index 06d340c98009..5f3e70568509 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -1579,7 +1579,6 @@ packages: /@opentelemetry/node/0.22.0_@opentelemetry+api@1.0.3: resolution: {integrity: sha512-+HhGbDruQ7cwejVOIYyxRa28uosnG8W95NiQZ6qE8PXXPsDSyGeftAPbtYpGit0H2f5hrVcMlwmWHeAo9xkSLA==} engines: {node: '>=8.0.0'} - deprecated: Package renamed to @opentelemetry/sdk-trace-node peerDependencies: '@opentelemetry/api': ^1.0.0 dependencies: @@ -11794,7 +11793,7 @@ packages: dev: false file:projects/mixed-reality-remote-rendering.tgz: - resolution: {integrity: sha512-bkO+RqEzutaWd9pgHnbYW+L49YzP+MnO19vEUxROPomVn4frVNBMOUv3tPdZ21k3A8HT+PHFSzU6zAUX0P8dPQ==, tarball: file:projects/mixed-reality-remote-rendering.tgz} + resolution: {integrity: sha512-nSnJO5YUQrADRM2Don+4TNMIbnZfSBaykUWTF5ZxWsbKcEP+g1nU0uM7tMWhPqZaY1XEdR55XIem4o40PWr8yQ==, tarball: file:projects/mixed-reality-remote-rendering.tgz} name: '@rush-temp/mixed-reality-remote-rendering' version: 0.0.0 dependencies: @@ -12585,7 +12584,7 @@ packages: dev: false file:projects/schema-registry-avro.tgz: - resolution: {integrity: sha512-iRbvRW1AI8qOZY+dkzisvXFgybYssX9NgChAuqaGV8dltHQaY46PCBwNYepCjB1GbFfVqz4bl4CKtvZ6zhogXQ==, tarball: file:projects/schema-registry-avro.tgz} + resolution: {integrity: sha512-es1wTz4ESP2fxE8Wky3jiVQdorQHXzokj57HKP5pNkP4WnDy+0p20f6dQZAgH1abgNsYYha8yK+vK/i2txJ+AQ==, tarball: file:projects/schema-registry-avro.tgz} name: '@rush-temp/schema-registry-avro' version: 0.0.0 dependencies: