From 0794b8b17fc8a0ca739395b0f30fa88bbf745191 Mon Sep 17 00:00:00 2001 From: Ramya Achutha Rao Date: Wed, 27 Oct 2021 14:11:52 -0700 Subject: [PATCH 1/2] Remove Node.js 10 from test matrix --- eng/pipelines/templates/jobs/smoke.tests.yml | 4 ++-- eng/pipelines/templates/stages/platform-matrix.json | 2 +- sdk/keyvault/keyvault-admin/platform-matrix.json | 2 +- sdk/keyvault/keyvault-keys/platform-matrix.json | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/eng/pipelines/templates/jobs/smoke.tests.yml b/eng/pipelines/templates/jobs/smoke.tests.yml index 44e4a42788cb..ed5908832363 100644 --- a/eng/pipelines/templates/jobs/smoke.tests.yml +++ b/eng/pipelines/templates/jobs/smoke.tests.yml @@ -84,7 +84,7 @@ jobs: # OSVmImage: "ubuntu-18.04" # SubscriptionConfiguration: $(sub-config-gov-test-resources) # ArmTemplateParameters: $(AzureUSGovernmentArmTemplateParameters) -# NodeTestVersion: "10.x" +# NodeTestVersion: "12.x" # Windows Node14 (AzureUSGovernment): # Pool: Azure Pipelines # OSVmImage: "windows-2019" @@ -102,7 +102,7 @@ jobs: # OSVmImage: "windows-2019" # SubscriptionConfiguration: $(sub-config-cn-test-resources) # ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters) -# NodeTestVersion: "10.x" +# NodeTestVersion: "12.x" pool: name: $(Pool) diff --git a/eng/pipelines/templates/stages/platform-matrix.json b/eng/pipelines/templates/stages/platform-matrix.json index f9e1997fb4d1..a5b0f9af2251 100644 --- a/eng/pipelines/templates/stages/platform-matrix.json +++ b/eng/pipelines/templates/stages/platform-matrix.json @@ -17,7 +17,7 @@ "Pool": "Azure Pipelines" } }, - "NodeTestVersion": ["10.x", "12.x", "14.x", "16.x"], + "NodeTestVersion": ["12.x", "14.x", "16.x"], "TestType": "node", "TestResultsFiles": "**/test-results.xml" }, diff --git a/sdk/keyvault/keyvault-admin/platform-matrix.json b/sdk/keyvault/keyvault-admin/platform-matrix.json index 9795f8f798c5..fd95c3344983 100644 --- a/sdk/keyvault/keyvault-admin/platform-matrix.json +++ b/sdk/keyvault/keyvault-admin/platform-matrix.json @@ -9,7 +9,7 @@ } }, "TestType": "node", - "NodeTestVersion": "10.x" + "NodeTestVersion": "12.x" } ] } diff --git a/sdk/keyvault/keyvault-keys/platform-matrix.json b/sdk/keyvault/keyvault-keys/platform-matrix.json index 6849dc719741..92b58bdd59fa 100644 --- a/sdk/keyvault/keyvault-keys/platform-matrix.json +++ b/sdk/keyvault/keyvault-keys/platform-matrix.json @@ -9,7 +9,7 @@ } }, "TestType": "node", - "NodeTestVersion": "10.x" + "NodeTestVersion": "12.x" }, { "Agent": { From 640ab7f856a75cc0f3738d1b294719c34538d449 Mon Sep 17 00:00:00 2001 From: Ramya Achutha Rao Date: Wed, 27 Oct 2021 14:36:25 -0700 Subject: [PATCH 2/2] Fix text that has node version --- eng/pipelines/templates/jobs/smoke.tests.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eng/pipelines/templates/jobs/smoke.tests.yml b/eng/pipelines/templates/jobs/smoke.tests.yml index ed5908832363..a084eb88a6df 100644 --- a/eng/pipelines/templates/jobs/smoke.tests.yml +++ b/eng/pipelines/templates/jobs/smoke.tests.yml @@ -79,7 +79,7 @@ jobs: SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources) ArmTemplateParameters: $(AzureCloudArmTemplateParameters) NodeTestVersion: "16.x" -# Linux Node10 (AzureUSGovernment): +# Linux Node12 (AzureUSGovernment): # Pool: Azure Pipelines # OSVmImage: "ubuntu-18.04" # SubscriptionConfiguration: $(sub-config-gov-test-resources) @@ -97,7 +97,7 @@ jobs: # SubscriptionConfiguration: $(sub-config-cn-test-resources) # ArmTemplateParameters: $(AzureChinaCloudArmTemplateParameters) # NodeTestVersion: "12.x" -# Windows Node10 (AzureChinaCloud): +# Windows Node12 (AzureChinaCloud): # Pool: Azure Pipelines # OSVmImage: "windows-2019" # SubscriptionConfiguration: $(sub-config-cn-test-resources)