Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service fabric e2e Identity tests #16187

Closed
wants to merge 12 commits into from
Closed

Service fabric e2e Identity tests #16187

wants to merge 12 commits into from

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Jul 4, 2021 •
edited
Loading

  • Running Identity e2e tests for Service Fabric

@ghost ghost added the Azure.Identity label Jul 4, 2021
@KarishmaGhiya KarishmaGhiya linked an issue Jul 4, 2021 that may be closed by this pull request
Create Identity e2e tests for running in Azure Service Fabric #11725
Closed
sadasant
sadasant reviewed Sep 24, 2021
View reviewed changes
sdk/identity/identity/test/manual-integration/AzureServiceFabric/INSTRUCTIONS.md

To use the provided templates:

1. Open `arm-templates/sfmitestsystem.parameters.json` and complete the fields `clusterName`, `clusterLocation`, and `applicationPackageUrl`. `clusterName` and `clusterLocation` should match the name and location of your Service Fabric cluster. `applicationPackageUrl` is the URL of the `.sfpkg` you uploaded to a storage account in the previous step. To find the URL, click on `sfmitestsystem.sfpkg` in the Portal to view its properties.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t find arm-templates/sfmitestsystem.parameters.json in this branch 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh so it’s the same arm-templates/cluster*?

sadasant
sadasant reviewed Sep 24, 2021
View reviewed changes
sdk/identity/identity/test/manual-integration/AzureServiceFabric/INSTRUCTIONS.md

```
az deployment group create --resource-group $RESOURCE_GROUP --template-file arm-templates\sfmitestsystem.template.json --parameters arm-templates\sfmitestsystem.parameters.json
az deployment group create --resource-group $RESOURCE_GROUP --template-file arm-templates\sfmitestuser.template.json --parameters arm-templates\sfmitestuser.parameters.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these two ARM templates don’t exist, and only the arm-templates/cluster* ones exist, these commands need to change.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with the similar pairs of commands below.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Oct 6, 2021
@JackTn @zhenglaizhang
@leni-msft @najian @raych1 @idear1203 @msyyc @AriZavala2 @PingZhu2232 @markcowl @Mohit-Chakraborty @roslynlu @Alancere @edwin-msft @dochollidayxx @yifan-zhou922 @parvsaxena @hvermis @xuepingd @laxmankumar12 @hjhhh3000vitae @RAY-316 @kangsun-ctrl @brpanask @rebecca337 @xunsun-commits @wanyang7 @soma-ms
CodeGen from PR 16289 in Azure/azure-rest-api-specs
038562e 
Dev sql microsoft.sql 2021 05 01 preview release (Azure#16289)

* add base for Microsoft.sql

* Update Readme.md

* update version in swagger example files

* remove ss

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* Sync sql 2021 05 01 with main branch (Azure#16236)

* Update comment.yml for publish pr (Azure#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (Azure#16170)

* bump avocado

* bump mocha

* remove submodule (Azure#16171)

* add azure-resource-manager-schema to servicelinker (Azure#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (Azure#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (Azure#16164)

Merging the change to have accurate Swagger

* Remove requirement of identity field in the request for TURN. (Azure#15966)

* Remove requirement of identity field in the request.

* Update PR

* Address comment

* change api version in readme for sdk release (Azure#16187)

* Add blockchain to latest profile

* Add additional types

* api version change

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>

* [Search] Rename types for better SDK code (Azure#16039)

* Rename types for better SDK code

* Rename Speller and Captions search options

* Reorder parameters to have consistency across APIs

* Remove 'SearchIndexer' prefix from projection selectors

Remove 'global' prefix from default flags on custom entities

* Change enum name AdlsGen2->AzureDataLakeStorageGen2

Change property name storageContainer->storageContainerName

* move additional .NET SDK renames to the REST spec

* Revert changes in KnowledgeStore which has GAed

* Revert changes in CustomEntityLookupSkill which has GAed

* Revert changes in SIKSBlobProjectionSelector which has GAed

* Revert changes in SearchIndexerDataSourceType which has GAed

* Rename ignoreResetRequirements->skipIndexerResetRequirementForCache

* fix validStreamingUnits (Azure#16143)

Co-authored-by: Roslyn Lu <[email protected]>

* Fix schemas readme files (Azure#16207)

* Fix schemas readme files

* fix ref

* add resourcemanager in module-name (Azure#16206)

* add resourcemanager in module-name

* add go track2 repo in readme.md

* fix

* Minor description update for createorupdate & update slot (Azure#15457)

* add scmMinTlsVersion

* modify description for createorupdate & update slot for all API versions

Co-authored-by: Edwin Diaz <[email protected]>

* [Hub Generated] Review request for Microsoft.Security to add version preview/2021-08-01-preview (Azure#16096)

* Adds base for updating Microsoft.Security from version stable/2021-07-01 to version 2021-08-01-preview

* Updates readme

* Updates API version in new specs and examples

* First pass at Microsoft.Security/standards for review/preview

* Addressing Round-1 feedback, adding missing descriptions and changing scoping to match ProxyResource type

* First pass for Microsoft.Security\standardComponents

* Changes to fix a typo in an example spec

* Added Microsoft.Security/standardAssignments

* Fix naming convention issue

* Removed types based on Hila's feedback

* Changes to data model for both API calls

* Fix example errors and typos

* Add systemData to Microsoft.Security/standards

* Changes to fix systemData linting

* un-nest systemData fields in examples

* More systemData placement

* Naming convention name to assignments from standardAssignment

* Additional example added

* Changes to address descriptive comments on field types

* Add systemData readOnly

* prettier-fix against examples

* Cleaned types to ref standard v2 common-types entry similar to securityForIoT

* Re-added v2 folder?

* Missed a change here?

* Cleanup of v2 type completely, updated readme.md

* Adds suppression to readme

* Adds suppression to readme

* Change modification to suppress operations linting

Co-authored-by: Adam Holliday <[email protected]>

* Yifanzhou/api version change (Azure#16191)

* remove Catalog

* update 2021-05-01-preview

* delete 2021-09-01

* Update readme.md

* Update purviewcatalog.json

* change read-only property (Azure#16209)

Co-authored-by: Parv Saxena <[email protected]>

* Update account.json - make CollectionReferece type writable (Azure#16208)

* Update account.json

Updating the CollectionReference to be writeable to unblock the customers.

* Update account.json

Need the default set in the client SDK

* Fixed an event name typo in its description. (Azure#16227)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview (Azure#15723)

* Introduce new API version for Microsoft.ProviderHub 2021-09-01-preview

* Add PrivateResourceProviderConfigurations

* Add PrivateRP examples

* Fix enum type.

* Fix enum again

* Prettier

* Fix prettier error

* Add readme.md + prettier

* Fix

* Fix avocado error

* Modify interface

* Fix issue

* Make it private preview

* Remove private RP changes

* Update SKU settings

Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>

* fluidrelay_readme_config (Azure#16192)

fluidrelay_readme_config

* Add community gallery proxy resource (Azure#16043)

* [Hub Generated] Public private branch 'dev-storagecache-Microsoft.StorageCache-2021-09-01' (Azure#16152)

* Adds base for updating Microsoft.StorageCache from version stable/2021-05-01 to version 2021-09-01

* Updates readme

* Updates API version in new specs and examples

* 2021-09-01 API

* Fix LintDiff

Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs (Azure#15946)

* Changed FSPG RestartParameter.failoverMode from string to enum for API 2021-06-01, 2021-06-01-preview, and 2021-06-15-privatepreview

* Change enum first letter to lower case

* Change to upper case

* Fix S360 bugs for swagger FSPG 2020-02-14-preview, 2021-06-01-preview and 2021-06-01 APIs

* Add email reminder when PR makes changes in Synapse (Azure#16116)

* add email reminder to synapse

* fix for comment

* ServiceBus add batch tag (Azure#16229)

* add code owner to synapse (Azure#16230)

* [Datafactory] Power Query model changes for multiple queries (Azure#16158)

* [Synapse] Add release tag for management SDK Oct. release (Azure#16213)

* update release tag

* fix for avocado

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

* Update from microsoft.sql 2021-05-01-preview to base branch (Azure#16184)

* Update comment.yml for publish pr (Azure#16166)

* Update comment.yml

* Update comment.yml

* Bump dependencies (Azure#16170)

* bump avocado

* bump mocha

* remove submodule (Azure#16171)

* add azure-resource-manager-schema to servicelinker (Azure#16176)

Co-authored-by: Nan Jiang <[email protected]>

* Update pr assignment config (Azure#16175)

* [Synapse] - fix scheme for Artifacts and update readme to include KQL scripts for October release (Azure#16035)

* [Synapse] - fix scheme for Notebook, Spark Job definition and SQL script

* Update dataset, linked service and pipeline

* Update release tag for october release

* Correct type of result limit

* Add arguments for SynapseSparkJobActivityTypeProperties

Co-authored-by: Dongwei Wang <[email protected]>

* fix (Azure#16164)

Merging the change to have accurate Swagger

* update swagger files

* update readme.md

* add missing json files

* update custom-words.txt to address the spelling check

* remove 201 define in ServerUpdate.json

* remove blank line

* address comments

* address the description comment

* update the swagger

* remove ManagedInstances_ListOutboundNetworkDependenciesByManagedInstance

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>

Co-authored-by: Tianen <[email protected]>
Co-authored-by: Zhenglai Zhang <[email protected]>
Co-authored-by: Lei Ni <[email protected]>
Co-authored-by: najian <[email protected]>
Co-authored-by: Nan Jiang <[email protected]>
Co-authored-by: Ray Chen <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: Dongwei Wang <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: AriZavala2 <[email protected]>
Co-authored-by: PingZhu2232 <[email protected]>
Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: Ping Zhu <[email protected]>
Co-authored-by: Mohit Chakraborty <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: Roslyn Lu <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: edwin-msft <[email protected]>
Co-authored-by: Edwin Diaz <[email protected]>
Co-authored-by: dochollidayxx <[email protected]>
Co-authored-by: Adam Holliday <[email protected]>
Co-authored-by: yifan-zhou922 <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: Parv Saxena <[email protected]>
Co-authored-by: hvermis <[email protected]>
Co-authored-by: xuepingd <[email protected]>
Co-authored-by: laxmankumar12 <[email protected]>
Co-authored-by: REDMOND\lakshv <[email protected]>
Co-authored-by: He Huang <[email protected]>
Co-authored-by: Zed Lei <[email protected]>
Co-authored-by: kangsun-ctrl <[email protected]>
Co-authored-by: brpanask <[email protected]>
Co-authored-by: rebecca337 <[email protected]>
Co-authored-by: Rebecca Dupuis <[email protected]>
Co-authored-by: xunsun-commits <[email protected]>
Co-authored-by: Wan Yang <[email protected]>
Co-authored-by: soma-ms <[email protected]>
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Feb 25, 2022
@ghost
Copy link

ghost commented Feb 25, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Mar 4, 2022
@ghost
Copy link

ghost commented Mar 4, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@KarishmaGhiya KarishmaGhiya reopened this Mar 5, 2022
@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Mar 5, 2022 •
edited
Loading

We'd like to keep this PR open till we get some more time to start working on this again. Need to reference both these - Azure/azure-sdk#901 (comment) and Azure/azure-sdk-for-python#21370

@ghost ghost removed the no-recent-activity There has been no recent activity on this issue. label Mar 5, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label May 6, 2022
@ghost
Copy link

ghost commented May 6, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this May 13, 2022
@ghost
Copy link

ghost commented May 13, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@KarishmaGhiya KarishmaGhiya removed the no-recent-activity There has been no recent activity on this issue. label Jun 13, 2022
@KarishmaGhiya KarishmaGhiya added this to the Backlog milestone Jun 13, 2022
@KarishmaGhiya KarishmaGhiya reopened this Jun 13, 2022
@ghost ghost added the no-recent-activity There has been no recent activity on this issue. label Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Hi @KarishmaGhiya. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@ghost ghost closed this Aug 27, 2022
@ghost
Copy link

ghost commented Aug 27, 2022

Hi @KarishmaGhiya. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing "/reopen" if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the "no-recent-activity" label; otherwise, this is likely to be closed again with the next cleanup pass.

@xirzec xirzec removed this from the Backlog milestone Nov 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadasant sadasant sadasant left review comments

@minhanh-phan minhanh-phan Awaiting requested review from minhanh-phan minhanh-phan will be requested when the pull request is marked ready for review minhanh-phan is a code owner

@maorleger maorleger Awaiting requested review from maorleger maorleger will be requested when the pull request is marked ready for review maorleger is a code owner

@schaabs schaabs Awaiting requested review from schaabs schaabs will be requested when the pull request is marked ready for review schaabs is a code owner

Assignees
No one assigned
Labels
Azure.Identity no-recent-activity There has been no recent activity on this issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Identity e2e tests for running in Azure Service Fabric
3 participants
@KarishmaGhiya @sadasant @xirzec