[communication][phone-numbers] enable samples #14814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
beltr0n
approved these changes
Apr 9, 2021
| "endpoint=https://resourceName.communication.azure.net/;accessKey=test-key"; | ||
|
|
||
| // create new client | ||
| const client = new PhoneNumbersClient(connectionString); | ||
|
|
||
| // You will need to set this environment variable or edit the following values | ||
| const phoneNumberToUpdate = process.env.PHONE_NUMBER_TO_UPDATE || "<phone number to update>"; | ||
| const phoneNumberToUpdate = | ||
| process.env.AZURE_COMMUNICATION_PHONE_NUMBER_TO_UPDATE || |
There was a problem hiding this comment.
I really like the naming convention as AZURE_COMMUNICATION_SAMPLES_CONNECTION_STRING, and i like how that simplifies it to 1 env var.
I wish there was something we could do for the phone number to only require 1 env var but I can't think of anything better
|
is there someone from outside our team we can loop in for this? |
0rland0Wats0n
requested review from
ankitarorabit,
danieljurek and
a team
as code owners
|
Fixes #14312 |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…to enable-phone-number-samples
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run js - communication-phone-numbers - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jay-most
pushed a commit
to jay-most/azure-sdk-for-js
that referenced
this pull request
Apr 26, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jul 5, 2021
[Hub Generated] Review request for Microsoft.Synapse to add version preview/2021-06-01-preview (Azure#14814) * Adds base for updating Microsoft.Synapse from version stable/2021-05-01 to version 2021-06-01-preview * Updates readme * Updates API version in new specs and examples * Add kustoPool.json to new API version + examples files + in readme.md * Add "type": "object" to definitions * Modify SKU to new name & size instead of previous name & tier * Add KustoPool stop * fix KustoPool Stop example params * Add KustoPool Start + example * Add KustoPool LanguageExtension Add/List/Remove * Add "type": "object" to LanguageExtensionsList * Add KustoPoolFollowerDatabases DETACH and LIST + examples * Add KustoPoolDatabasePrincipals ADD & LIST + examples * Add missing DatabasePrincipalListRequest definition * Add "type": "object" to FollowerDatabaseListResult, DatabasePrincipalListRequest, DatabasePrincipalListResult * Add KustoPoolDatabasePrincipalsRemove + example * Remove redundant newline * Add AttachedDatabaseConfigurations to KustoPool + examples * Add AttachedDatabaseConfigurationNameParameter * Fixes for AttachedDatabaseConfiguration * Add "type": "object" to TableLevelSharingProperties * Fix example of KustoPoolAttachedDatabaseConfigurationCreateOrUpdate.json * Add DataConnectionValidation to kustoPool.json + example * Fixes to DataConnectionValidation * Remove properties from KustoPoolDataConnectionValidation.json * Fix object instead of array at KustoPoolDataConnectionValidation.json example * Fix indentation at KustoPoolDataConnectionValidation.json * Add KustoPoolPrincipalAssignmentCheckNameAvailability to kustoPool.json + example * Remove redundant slash * Add KustoPoolDatabasePrincipalAssignmentsCheckNameAvailability to kustoPool.json + example * Fix in KustoPoolDatabasePrincipalAssignmentsCheckNameAvailability.json * Add KustoPoolDataConnectionCheckNameAvailability.json + example * Add KustoPoolListSkus + example * Add kustoSkus path to kustoPool.json + example * Remove {databaseName}/addPrincipals, listPrincipals, removePrincipals. Remove related definitions + example files * Change workspaceUid to workspaceUID to keep convention with Workspace resource * Add new KustoPool properties: optimizedAutoscale enableStreamingIngest enablePurge languageExtensions * Change "KustoCluster" to "KustoPool" and remove engineType property * Change "kustoSkus" endpoint to "skus" * Add KustoPool databases CheckNameAvailability + examples * Re-position kustoPoolCheckNameAvailability * Fix typo in example * Minor adjustments in KustoPool databases CheckNameAvailability * Change to "validateDataConnection" * Revert back to DataConnectionValidation to keep consistency with kusto swagger Co-authored-by: Amit Elran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables all phone numbers samples to run in CI (except purchase and release).