From bda5c8e02e536ca8d58b5d9498c1aa0ea10de914 Mon Sep 17 00:00:00 2001 From: Richard Park Date: Thu, 18 Feb 2021 23:01:35 -0800 Subject: [PATCH 1/3] Problem #1 - the underlying value has changed (it used to be a CanonicalCode.OK (0) but now is StatusCode.OK (1)). --- .../test/common/scenario/basic.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts b/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts index e5b2f7f0abc8..673e5310cbbc 100644 --- a/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts +++ b/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts @@ -91,7 +91,7 @@ export class BasicScenario implements Scenario { version: 1, name: "BasicScenario.Root", duration: msToTimeSpan(600), - responseCode: "0", + responseCode: StatusCode.OK.toString(), success: true, properties: { foo: "bar" @@ -108,7 +108,7 @@ export class BasicScenario implements Scenario { name: "BasicScenario.Child.1", duration: msToTimeSpan(100), success: true, - resultCode: "0", + resultCode: StatusCode.OK.toString(), properties: { numbers: "123" } @@ -125,7 +125,7 @@ export class BasicScenario implements Scenario { name: "BasicScenario.Child.2", duration: msToTimeSpan(100), success: true, - resultCode: "0", + resultCode: StatusCode.OK.toString(), properties: { numbers: "1234" } From 76bed3c7d00253e3678bee2f4c7d447d1bcd970b Mon Sep 17 00:00:00 2001 From: Richard Park Date: Thu, 18 Feb 2021 23:05:18 -0800 Subject: [PATCH 2/3] Fixing issue where the test failing wasn't actually passed on to the test framework. --- .../test/functional/trace.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts b/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts index 641e5b98ddca..990611c4a18f 100644 --- a/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts +++ b/sdk/monitor/monitor-opentelemetry-exporter/test/functional/trace.test.ts @@ -46,7 +46,7 @@ describe("Trace Exporter Scenarios", () => { }); }) .catch((e) => { - throw e; + done(e); }); }); }); From 1f17001376a4efc5b90dcfb26ba2a97a49cd096d Mon Sep 17 00:00:00 2001 From: Richard Park Date: Fri, 19 Feb 2021 15:33:29 -0800 Subject: [PATCH 3/3] .16 => .17 (StatusCode ==> SpanStatusCode) rename --- .../test/common/scenario/basic.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts b/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts index 673e5310cbbc..1a34d2a81ea2 100644 --- a/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts +++ b/sdk/monitor/monitor-opentelemetry-exporter/test/common/scenario/basic.ts @@ -91,7 +91,7 @@ export class BasicScenario implements Scenario { version: 1, name: "BasicScenario.Root", duration: msToTimeSpan(600), - responseCode: StatusCode.OK.toString(), + responseCode: SpanStatusCode.OK.toString(), success: true, properties: { foo: "bar" @@ -108,7 +108,7 @@ export class BasicScenario implements Scenario { name: "BasicScenario.Child.1", duration: msToTimeSpan(100), success: true, - resultCode: StatusCode.OK.toString(), + resultCode: SpanStatusCode.OK.toString(), properties: { numbers: "123" } @@ -125,7 +125,7 @@ export class BasicScenario implements Scenario { name: "BasicScenario.Child.2", duration: msToTimeSpan(100), success: true, - resultCode: StatusCode.OK.toString(), + resultCode: SpanStatusCode.OK.toString(), properties: { numbers: "1234" }