From bd3df53af526f1e6704786f403fb9047ce1a3864 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 09:51:26 -0800 Subject: [PATCH 01/38] Fix linting rule for ts-package-json-homepage --- .../docs/rules/ts-package-json-homepage.md | 6 ++++++ .../src/rules/ts-package-json-homepage.ts | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md index 3526cf8173da..4671fce07d20 100644 --- a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md +++ b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md @@ -32,6 +32,12 @@ Requires `homepage` in `package.json` to be set to the library's readme. } ``` +```json +{ + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/" +} +``` + ```json { "homepage": "https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/service-bus/README.md" diff --git a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts index 07d1ec1b3e61..74ca116a8525 100644 --- a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts +++ b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts @@ -37,7 +37,7 @@ export = { const nodeValue = node.value as Literal; if ( - !/^https:\/\/github.com\/Azure\/azure-sdk-for-js\/(blob|tree)\/master\/sdk\/(([a-z]+-)*[a-z]+\/)+(README\.md)?$/.test( + !/^https:\/\/github.com\/Azure\/azure-sdk-for-js\/(blob|tree)\/master\/sdk(\/([a-z]+-)*[a-z]+)+(\/README\.md)?$/.test( nodeValue.value as string ) ) { From deead72442ae6c39781f53596c44e650f55712c2 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 09:52:03 -0800 Subject: [PATCH 02/38] app-configuration package.json lint --- sdk/appconfiguration/app-configuration/package.json | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/sdk/appconfiguration/app-configuration/package.json b/sdk/appconfiguration/app-configuration/package.json index ec06f7517c3f..b2468f22b0ae 100644 --- a/sdk/appconfiguration/app-configuration/package.json +++ b/sdk/appconfiguration/app-configuration/package.json @@ -9,17 +9,15 @@ "azure", "typescript", "browser", - "isomorphic" + "isomorphic", + "cloud" ], "license": "MIT", "main": "./dist/index.js", "module": "./dist-esm/src/index.js", "types": "./types/app-configuration.d.ts", "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/appconfiguration/app-configuration", - "repository": { - "type": "git", - "url": "https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, @@ -70,6 +68,9 @@ "unit-test": "npm run unit-test:node && npm run unit-test:browser", "docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --mode file --out ./dist/docs ./src" }, + "engines": { + "node": ">=8.0.0" + }, "sideEffects": false, "autoPublish": false, "//metadata": { From 972104a9c85753403a119c32e2ebf56abe11ad91 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 09:55:35 -0800 Subject: [PATCH 03/38] ai-anomaly-detector lint --- sdk/anomalydetector/ai-anomaly-detector/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/anomalydetector/ai-anomaly-detector/package.json b/sdk/anomalydetector/ai-anomaly-detector/package.json index 9a5615b70ba1..0bfeffa953f2 100644 --- a/sdk/anomalydetector/ai-anomaly-detector/package.json +++ b/sdk/anomalydetector/ai-anomaly-detector/package.json @@ -58,7 +58,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/anomalydetector/ai-anomaly-detector/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/anomalydetector/ai-anomaly-detector", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From ba94b58e07f17d306c2c590ba3346173e7a09f3f Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 09:57:49 -0800 Subject: [PATCH 04/38] ai-form-recognizer fix --- sdk/formrecognizer/ai-form-recognizer/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/formrecognizer/ai-form-recognizer/package.json b/sdk/formrecognizer/ai-form-recognizer/package.json index 49b0438864a5..3cd65d6c3154 100644 --- a/sdk/formrecognizer/ai-form-recognizer/package.json +++ b/sdk/formrecognizer/ai-form-recognizer/package.json @@ -19,7 +19,7 @@ "./dist-esm/src/utils/utils.node.js": "./dist-esm/src/utils/utils.browser.js" }, "types": "./types/ai-form-recognizer.d.ts", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/textanalytics/ai-text-analytics/README.md", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/formrecognizer/ai-form-recognizer", "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" From 138ca626b6d7f22eb9f37dfcae43460b2aef556e Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:15:27 -0800 Subject: [PATCH 05/38] search-documents fix --- sdk/search/search-documents/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/search/search-documents/package.json b/sdk/search/search-documents/package.json index b1c3d0258975..bd940e6905ba 100644 --- a/sdk/search/search-documents/package.json +++ b/sdk/search/search-documents/package.json @@ -72,7 +72,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/search/search-documents/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/search/search-documents", "sideEffects": false, "dependencies": { "@azure/core-auth": "^1.1.3", From d72bf0d8dfb93a16a1d1972e23a46c9877a44b1f Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:18:46 -0800 Subject: [PATCH 06/38] communication-admin fix --- .../communication-administration/package.json | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/sdk/communication/communication-administration/package.json b/sdk/communication/communication-administration/package.json index b515442a7068..53b8501e6a90 100644 --- a/sdk/communication/communication-administration/package.json +++ b/sdk/communication/communication-administration/package.json @@ -50,7 +50,7 @@ "LICENSE" ], "keywords": [ - "Azure", + "azure", "cloud", "communication" ], @@ -59,7 +59,11 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-administration/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-administration", + "repository": "github:Azure/azure-sdk-for-js", + "bugs": { + "url": "https://github.com/Azure/azure-sdk-for-js/issues" + }, "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 5fab68061a3f1f02ff0ec372f6b55fbd073e21f8 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:20:46 -0800 Subject: [PATCH 07/38] communication-chat fix --- sdk/communication/communication-chat/package.json | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json index a28abbd89ce0..2c12001d0da5 100644 --- a/sdk/communication/communication-chat/package.json +++ b/sdk/communication/communication-chat/package.json @@ -39,8 +39,7 @@ "dist-esm/src/", "types/", "README.md", - "LICENSE", - "src" + "LICENSE" ], "browser": { "./dist-esm/src/signaling/signalingClient.js": "./dist-esm/src/signaling/signalingClient.browser.js" @@ -61,7 +60,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-chat/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-chat", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 8d4e840488feaebeab58fb85321daa1e2ab4912d Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:22:07 -0800 Subject: [PATCH 08/38] communication-common fix --- sdk/communication/communication-common/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/communication/communication-common/package.json b/sdk/communication/communication-common/package.json index 41849fc95a72..541848ce05c1 100644 --- a/sdk/communication/communication-common/package.json +++ b/sdk/communication/communication-common/package.json @@ -59,7 +59,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-common/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-common", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 161cb33227f16a7ea98d2972d31130cfad9c8a3b Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:23:06 -0800 Subject: [PATCH 09/38] communication-sms fix --- sdk/communication/communication-sms/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/communication/communication-sms/package.json b/sdk/communication/communication-sms/package.json index 41f841318fa1..09957db9abdf 100644 --- a/sdk/communication/communication-sms/package.json +++ b/sdk/communication/communication-sms/package.json @@ -63,7 +63,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-sms/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-sms", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 42959a1efe5bfe910ff4ddb9ebe6ea1d31796d16 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:26:54 -0800 Subject: [PATCH 10/38] core-client fix --- sdk/core/core-client/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/core-client/package.json b/sdk/core/core-client/package.json index 1569729ebe72..423985f81e43 100644 --- a/sdk/core/core-client/package.json +++ b/sdk/core/core-client/package.json @@ -72,7 +72,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-client/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-client", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 02e55c042dcc412387939b08cfee6a5185421bdb Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 10:40:24 -0800 Subject: [PATCH 11/38] core-https fix --- sdk/core/core-https/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/core-https/package.json b/sdk/core/core-https/package.json index 1f2d75409fae..1c140d8e2bb8 100644 --- a/sdk/core/core-https/package.json +++ b/sdk/core/core-https/package.json @@ -76,7 +76,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-https/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-https", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "//metadata": { From ee02770590b5500108dc1d7876f51ce7c2acbbb8 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:03:34 -0800 Subject: [PATCH 12/38] core-xml fix --- sdk/core/core-xml/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/core/core-xml/package.json b/sdk/core/core-xml/package.json index b7846e083936..143679c9d5c7 100644 --- a/sdk/core/core-xml/package.json +++ b/sdk/core/core-xml/package.json @@ -72,7 +72,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-xml/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-xml", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 8960d236c1d2a9c9340d1efed80b5ef83404a583 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:15:07 -0800 Subject: [PATCH 13/38] Partially fix cosmosdb --- sdk/cosmosdb/cosmos/.eslintrc.json | 2 ++ sdk/cosmosdb/cosmos/package.json | 7 +++++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/sdk/cosmosdb/cosmos/.eslintrc.json b/sdk/cosmosdb/cosmos/.eslintrc.json index 276df33e5e47..2eb2c2b08c0e 100644 --- a/sdk/cosmosdb/cosmos/.eslintrc.json +++ b/sdk/cosmosdb/cosmos/.eslintrc.json @@ -9,6 +9,8 @@ "@typescript-eslint/no-extraneous-class": "error", "dot-notation": "off", "some-rule": "off", + "@azure/azure-sdk/ts-package-json-module": "off", + "@azure/azure-sdk/ts-package-json-types": "off", "@typescript-eslint/tslint/config": [ "error", { diff --git a/sdk/cosmosdb/cosmos/package.json b/sdk/cosmosdb/cosmos/package.json index a6c29d01f303..8626678ab206 100644 --- a/sdk/cosmosdb/cosmos/package.json +++ b/sdk/cosmosdb/cosmos/package.json @@ -32,7 +32,7 @@ "README.md", "LICENSE" ], - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos", "sideEffects": false, "types": "./dist/types/latest/index.d.ts", "typesVersions": { @@ -42,7 +42,7 @@ ] } }, - "engine": { + "engines": { "node": ">=8.0.0" }, "scripts": { @@ -79,6 +79,9 @@ }, "repository": "github:Azure/azure-sdk-for-js", "license": "MIT", + "bugs": { + "url": "https://github.com/Azure/azure-sdk-for-js/issues" + }, "tsdoc": { "tsdocFlavor": "AEDoc" }, From ffcc2f9906c5568188b2df898f90b8e0da67c704 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:43:02 -0800 Subject: [PATCH 14/38] opentelemetry fix --- sdk/core/core-xml/package.json | 3 +-- .../package.json | 18 +++++++++--------- 2 files changed, 10 insertions(+), 11 deletions(-) diff --git a/sdk/core/core-xml/package.json b/sdk/core/core-xml/package.json index 143679c9d5c7..7e07fee06d7b 100644 --- a/sdk/core/core-xml/package.json +++ b/sdk/core/core-xml/package.json @@ -61,8 +61,7 @@ "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", - "cloud", - "Azure" + "cloud" ], "author": "Microsoft Corporation", "license": "MIT", diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json index 3b3076d11f22..b0060b39a729 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json @@ -1,12 +1,12 @@ { "name": "@azure/opentelemetry-exporter-azure-monitor", - "author": "appinsightssdk@microsoft.com", + "author": "Microsoft Corporation", "sdk-type": "client", "version": "1.0.0-beta.1", "description": "Application Insights exporter for the OpenTelemetry JavaScript (Node.js) SDK", - "main": "dist-esm/src/index.js", + "main": "dist/index.js", "module": "dist-esm/src/index.js", - "types": "types/src/index.d.ts", + "types": "types/opentelemetry-exporter-azure-monitor.d.ts", "scripts": { "clean": "rimraf dist-esm types dist", "build:autorest": "autorest ./swagger/README.md --typescript --v3", @@ -35,23 +35,22 @@ "docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --mode file --out ./dist/docs ./src" }, "engines": { - "node": ">=8.3.0" + "node": ">=8.0.0" }, "files": [ "dist-esm/src/", "dist/src/", "browser/src/", "types/src/", - "src/", "README.md", "SECURITY.md", "LICENSE" ], "license": "MIT", "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/monitor/opentelemetry-exporter-azure-monitor", - "repository": { - "type": "git", - "url": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/monitor/opentelemetry-exporter-azure-monitor" + "repository": "github:Azure/azure-sdk-for-js", + "bugs": { + "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "//metadata": { @@ -96,6 +95,7 @@ "javascript", "applicationinsights", "opentelemetry", - "exporter" + "exporter", + "cloud" ] } From 5f2d147e19aeb90b25ddd7282f21b70808e04774 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:48:36 -0800 Subject: [PATCH 15/38] eventhubs --- sdk/eventhub/event-hubs/package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sdk/eventhub/event-hubs/package.json b/sdk/eventhub/event-hubs/package.json index d0e36f9ae5f9..0eaf3cf70c52 100644 --- a/sdk/eventhub/event-hubs/package.json +++ b/sdk/eventhub/event-hubs/package.json @@ -18,6 +18,9 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, + "engines": { + "node": ">=8.0.0" + }, "main": "./dist/index.js", "module": "dist-esm/src/index.js", "types": "./types/latest/event-hubs.d.ts", From 76d46e0155fc7dac87659904977575415c0911e2 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:50:32 -0800 Subject: [PATCH 16/38] eventhub-checkpoint-blob --- sdk/eventhub/eventhubs-checkpointstore-blob/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/eventhub/eventhubs-checkpointstore-blob/package.json b/sdk/eventhub/eventhubs-checkpointstore-blob/package.json index 3f47d6940126..6f06c04162c9 100644 --- a/sdk/eventhub/eventhubs-checkpointstore-blob/package.json +++ b/sdk/eventhub/eventhubs-checkpointstore-blob/package.json @@ -15,12 +15,12 @@ "events" ], "bugs": { - "url": "https://github.com/azure/azure-sdk-for-js/issues" + "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, "main": "./dist/index.js", "module": "dist-esm/src/index.js", "types": "./typings/eventhubs-checkpointstore-blob.d.ts", - "engine": { + "engines": { "node": ">=8.0.0" }, "files": [ From 4d3b9e196b6cf57a36340b372318b4e48df5653d Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 11:53:00 -0800 Subject: [PATCH 17/38] event-processor-host --- sdk/eventhub/event-processor-host/package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/eventhub/event-processor-host/package.json b/sdk/eventhub/event-processor-host/package.json index 6e5a157974b5..4ea3f537fc87 100644 --- a/sdk/eventhub/event-processor-host/package.json +++ b/sdk/eventhub/event-processor-host/package.json @@ -5,7 +5,7 @@ "description": "Azure Event Processor Host (Event Hubs) SDK for JS.", "author": "Microsoft Corporation", "license": "MIT", - "homepage": "http://github.com/azure/azure-sdk-for-js", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-processor-host", "repository": "github:Azure/azure-sdk-for-js", "sideEffects": false, "keywords": [ @@ -16,12 +16,12 @@ "events" ], "bugs": { - "url": "https://github.com/azure/azure-sdk-for-js/issues" + "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, "main": "./dist/index.js", "module": "dist-esm/src/index.js", "types": "./typings/event-processor-host.d.ts", - "engine": { + "engines": { "node": ">=8.0.0" }, "files": [ From 14de05b1d4ba90b6c539bd4cfa54377df487154a Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:02:25 -0800 Subject: [PATCH 18/38] schema-registry-avro --- sdk/schemaregistry/schema-registry-avro/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/schemaregistry/schema-registry-avro/package.json b/sdk/schemaregistry/schema-registry-avro/package.json index 4711d236bd1e..2b7a758bd5f3 100644 --- a/sdk/schemaregistry/schema-registry-avro/package.json +++ b/sdk/schemaregistry/schema-registry-avro/package.json @@ -57,7 +57,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry-avro/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry-avro", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 97b6d92337a208d5d0e9f89769c31bff41e3ac60 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:03:36 -0800 Subject: [PATCH 19/38] service-bus --- sdk/servicebus/service-bus/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/servicebus/service-bus/package.json b/sdk/servicebus/service-bus/package.json index 71bd89886cf9..49af3ba4e470 100644 --- a/sdk/servicebus/service-bus/package.json +++ b/sdk/servicebus/service-bus/package.json @@ -33,7 +33,7 @@ ] } }, - "engine": { + "engines": { "node": ">=8.0.0" }, "files": [ From 6e432e4eaabfe276e122f3016c5da5eb3afa8ab6 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:15:15 -0800 Subject: [PATCH 20/38] fix up opentelemetry rollups --- .../opentelemetry-exporter-azure-monitor/api-extractor.json | 4 ++-- sdk/monitor/opentelemetry-exporter-azure-monitor/package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/api-extractor.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/api-extractor.json index 147d20f2bf1c..0601238f5944 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/api-extractor.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/api-extractor.json @@ -9,9 +9,9 @@ "reportFolder": "./review" }, "dtsRollup": { - "enabled": false, + "enabled": true, "untrimmedFilePath": "", - "publicTrimmedFilePath": "./types/monitor-exporter.d.ts" + "publicTrimmedFilePath": "./types/latest/opentelemetry-exporter-azure-monitor.d.ts" }, "messages": { "tsdocMessageReporting": { diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json index b0060b39a729..7fb3996ba541 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json @@ -6,7 +6,7 @@ "description": "Application Insights exporter for the OpenTelemetry JavaScript (Node.js) SDK", "main": "dist/index.js", "module": "dist-esm/src/index.js", - "types": "types/opentelemetry-exporter-azure-monitor.d.ts", + "types": "types/latest/opentelemetry-exporter-azure-monitor.d.ts", "scripts": { "clean": "rimraf dist-esm types dist", "build:autorest": "autorest ./swagger/README.md --typescript --v3", From 18036976f78b81bafe933cb28cd885268c18beab Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:28:51 -0800 Subject: [PATCH 21/38] storage-internal-avro --- sdk/eventhub/event-hubs/package.json | 3 --- .../storage-internal-avro/api-extractor.json | 2 +- .../storage-internal-avro/package.json | 23 +++++++++++++++---- .../storage-internal-avro/tsconfig.json | 2 +- 4 files changed, 21 insertions(+), 9 deletions(-) diff --git a/sdk/eventhub/event-hubs/package.json b/sdk/eventhub/event-hubs/package.json index 0eaf3cf70c52..2531dc4e84a0 100644 --- a/sdk/eventhub/event-hubs/package.json +++ b/sdk/eventhub/event-hubs/package.json @@ -34,9 +34,6 @@ "browser": { "./dist-esm/src/util/runtimeInfo.js": "./dist-esm/src/util/runtimeInfo.browser.js" }, - "engine": { - "node": ">=8.0.0" - }, "files": [ "dist/", "dist-esm/src/", diff --git a/sdk/storage/storage-internal-avro/api-extractor.json b/sdk/storage/storage-internal-avro/api-extractor.json index 77fe97737d88..6b50cf6b2ecc 100644 --- a/sdk/storage/storage-internal-avro/api-extractor.json +++ b/sdk/storage/storage-internal-avro/api-extractor.json @@ -11,7 +11,7 @@ "dtsRollup": { "enabled": true, "untrimmedFilePath": "", - "publicTrimmedFilePath": "./typings/latest/storage-internal-avro.d.ts" + "publicTrimmedFilePath": "./types/latest/storage-internal-avro.d.ts" }, "messages": { "tsdocMessageReporting": { diff --git a/sdk/storage/storage-internal-avro/package.json b/sdk/storage/storage-internal-avro/package.json index 79eda4a981c6..3eb008df477a 100644 --- a/sdk/storage/storage-internal-avro/package.json +++ b/sdk/storage/storage-internal-avro/package.json @@ -1,14 +1,22 @@ { "name": "@azure/storage-internal-avro", - "sideEffect": false, + "sideEffects": false, "private": true, "author": "Microsoft Corporation", "version": "1.0.0", "description": "internal avro parser", "license": "MIT", "repository": "github:Azure/azure-sdk-for-js", - "main": "./srt/index.ts", - "module": "dist-esm/index.js", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-internal-avro", + "bugs": { + "url": "https://github.com/Azure/azure-sdk-for-js/issues" + }, + "main": "./dist/index.js", + "module": "dist-esm/src/index.js", + "keywords": [ + "azure", + "cloud" + ], "browser": { "./dist-esm/storage-internal-avro/src/index.js": "./dist-esm/storage-internal-avro/src/index.browser.js", "./dist-esm/storage-internal-avro/src/utils/utils.node.js": "./dist-esm/storage-internal-avro/src/utils/utils.browser.js", @@ -17,10 +25,17 @@ "os": false, "process": false }, - "types": "./types/index.d.ts", + "types": "./types/latest/storage-internal-avro.d.ts", "engines": { "node": ">=8.0.0" }, + "files": [ + "dist/", + "dist-esm/src/", + "types/latest", + "README.md", + "LICENSE" + ], "scripts": { "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit", "build:es6": "tsc -p tsconfig.json", diff --git a/sdk/storage/storage-internal-avro/tsconfig.json b/sdk/storage/storage-internal-avro/tsconfig.json index 7d0f438f54f6..dbc93666cc3c 100644 --- a/sdk/storage/storage-internal-avro/tsconfig.json +++ b/sdk/storage/storage-internal-avro/tsconfig.json @@ -16,7 +16,7 @@ "declaration": true, "declarationMap": true, "importHelpers": true, - "declarationDir": "./typings/latest", + "declarationDir": "./types/latest", "lib": ["dom", "es5", "es6", "es7", "esnext"], "esModuleInterop": true }, From ea33dfd0eda4e1d865fb54b29f956ecc99899117 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:33:29 -0800 Subject: [PATCH 22/38] storage-blob --- sdk/storage/storage-blob/.eslintrc.json | 7 +++++++ sdk/storage/storage-blob/package.json | 14 ++++++-------- 2 files changed, 13 insertions(+), 8 deletions(-) create mode 100644 sdk/storage/storage-blob/.eslintrc.json diff --git a/sdk/storage/storage-blob/.eslintrc.json b/sdk/storage/storage-blob/.eslintrc.json new file mode 100644 index 000000000000..bf70df6fd8eb --- /dev/null +++ b/sdk/storage/storage-blob/.eslintrc.json @@ -0,0 +1,7 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + "@azure/azure-sdk/ts-package-json-module": "warn" + } +} diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json index fa78c1caa1a8..35f0c8a81245 100644 --- a/sdk/storage/storage-blob/package.json +++ b/sdk/storage/storage-blob/package.json @@ -27,7 +27,7 @@ ] } }, - "engine": { + "engines": { "node": ">=8.0.0" }, "scripts": { @@ -73,14 +73,12 @@ "README.md", "LICENSE" ], - "repository": { - "type": "git", - "url": "git+https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", - "atorage", - "alob", + "storage", + "blob", + "cloud", "node.js", "typescript", "javascript", @@ -91,7 +89,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob", "sideEffects": false, "//metadata": { "constantPaths": [ From b79dafe0e61a31c2feb51e91d11d8d69c8b346cb Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:39:37 -0800 Subject: [PATCH 23/38] storage-blob-changefeed --- sdk/storage/storage-blob-changefeed/.eslintrc.json | 7 +++++++ sdk/storage/storage-blob-changefeed/package.json | 12 +++++------- 2 files changed, 12 insertions(+), 7 deletions(-) create mode 100644 sdk/storage/storage-blob-changefeed/.eslintrc.json diff --git a/sdk/storage/storage-blob-changefeed/.eslintrc.json b/sdk/storage/storage-blob-changefeed/.eslintrc.json new file mode 100644 index 000000000000..bf70df6fd8eb --- /dev/null +++ b/sdk/storage/storage-blob-changefeed/.eslintrc.json @@ -0,0 +1,7 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + "@azure/azure-sdk/ts-package-json-module": "warn" + } +} diff --git a/sdk/storage/storage-blob-changefeed/package.json b/sdk/storage/storage-blob-changefeed/package.json index fa3d15eff74b..fe70e19a89c6 100644 --- a/sdk/storage/storage-blob-changefeed/package.json +++ b/sdk/storage/storage-blob-changefeed/package.json @@ -1,7 +1,7 @@ { "name": "@azure/storage-blob-changefeed", "sdk-type": "client", - "version": "12.0.0-preview.3", + "version": "12.0.0-beta.3", "description": "Microsoft Azure Storage SDK for JavaScript - Blob Change Feed", "main": "./dist/index.js", "module": "./dist-esm/storage-blob-changefeed/src/index.js", @@ -20,7 +20,7 @@ ] } }, - "engine": { + "engines": { "node": ">=8.0.0" }, "scripts": { @@ -66,14 +66,12 @@ "README.md", "LICENSE" ], - "repository": { - "type": "git", - "url": "git+https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", "storage", "blob", + "cloud", "changefeed", "node.js", "typescript", @@ -85,7 +83,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob-changefeed", "sideEffects": false, "//metadata": { "constantPaths": [ From 9e33ca82f4272f054fe8261bc966e92b787b0d24 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:41:42 -0800 Subject: [PATCH 24/38] storage-file-share --- sdk/storage/storage-file-share/package.json | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/sdk/storage/storage-file-share/package.json b/sdk/storage/storage-file-share/package.json index 51377e13382c..331974c1dd27 100644 --- a/sdk/storage/storage-file-share/package.json +++ b/sdk/storage/storage-file-share/package.json @@ -23,7 +23,7 @@ ] } }, - "engine": { + "engines": { "node": ">=8.0.0" }, "scripts": { @@ -67,14 +67,12 @@ "README.md", "LICENSE" ], - "repository": { - "type": "git", - "url": "git+https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", "storage", "file", + "cloud", "node.js", "typescript", "javascript", @@ -85,7 +83,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-share", "sideEffects": false, "//metadata": { "constantPaths": [ From 81bf0bf8b047ef8b20b5a14f4b1f2fc5c3b14d8a Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:43:39 -0800 Subject: [PATCH 25/38] storage-file-datalake --- sdk/storage/storage-file-datalake/.eslintrc.json | 7 +++++++ sdk/storage/storage-file-datalake/package.json | 10 ++++------ 2 files changed, 11 insertions(+), 6 deletions(-) create mode 100644 sdk/storage/storage-file-datalake/.eslintrc.json diff --git a/sdk/storage/storage-file-datalake/.eslintrc.json b/sdk/storage/storage-file-datalake/.eslintrc.json new file mode 100644 index 000000000000..bf70df6fd8eb --- /dev/null +++ b/sdk/storage/storage-file-datalake/.eslintrc.json @@ -0,0 +1,7 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + "@azure/azure-sdk/ts-package-json-module": "warn" + } +} diff --git a/sdk/storage/storage-file-datalake/package.json b/sdk/storage/storage-file-datalake/package.json index 095d572e9032..2f85a82f0ad2 100644 --- a/sdk/storage/storage-file-datalake/package.json +++ b/sdk/storage/storage-file-datalake/package.json @@ -23,7 +23,7 @@ "os": false, "process": false }, - "engine": { + "engines": { "node": ">=8.0.0" }, "scripts": { @@ -68,15 +68,13 @@ "LICENSE" ], "sideEffects": false, - "repository": { - "type": "git", - "url": "git+https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", "storage", "ADLS", "DFS", + "cloud", "datalake", "node.js", "typescript", @@ -88,7 +86,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-datalake", "//metadata": { "constantPaths": [ { From b912d5b08fc2992df6724ea71c705c3baafbf6b9 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:44:53 -0800 Subject: [PATCH 26/38] storage-queue --- sdk/storage/storage-queue/package.json | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sdk/storage/storage-queue/package.json b/sdk/storage/storage-queue/package.json index 903e18d73e68..2f6c9af75112 100644 --- a/sdk/storage/storage-queue/package.json +++ b/sdk/storage/storage-queue/package.json @@ -64,14 +64,12 @@ "README.md", "LICENSE" ], - "repository": { - "type": "git", - "url": "git+https://github.com/Azure/azure-sdk-for-js.git" - }, + "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", "storage", "queue", + "cloud", "node.js", "typescript", "javascript", @@ -82,7 +80,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js#readme", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-queue", "sideEffects": false, "//metadata": { "constantPaths": [ From f50056954cb3d6c64deed89be5b7c9844109bd6c Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:47:41 -0800 Subject: [PATCH 27/38] data-tables --- sdk/tables/data-tables/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/tables/data-tables/package.json b/sdk/tables/data-tables/package.json index cbf2646c1351..15a10abdb101 100644 --- a/sdk/tables/data-tables/package.json +++ b/sdk/tables/data-tables/package.json @@ -62,7 +62,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/tables/data-tables/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/tables/data-tables", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 6a2db02f213fa93ecc98fb0d7f15a77042c975d3 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 12:48:29 -0800 Subject: [PATCH 28/38] template --- sdk/template/template/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/template/template/package.json b/sdk/template/template/package.json index 45445a5d22dc..0ac4132974a8 100644 --- a/sdk/template/template/package.json +++ b/sdk/template/template/package.json @@ -57,7 +57,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/template/template/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/template/template", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 2a13174e6c45b1d9056f4b73b04324462bb468c6 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 13:03:48 -0800 Subject: [PATCH 29/38] test recorder --- sdk/test-utils/recorder/.eslintrc.json | 8 ++++++++ sdk/test-utils/recorder/package.json | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) create mode 100644 sdk/test-utils/recorder/.eslintrc.json diff --git a/sdk/test-utils/recorder/.eslintrc.json b/sdk/test-utils/recorder/.eslintrc.json new file mode 100644 index 000000000000..83e7985c45bf --- /dev/null +++ b/sdk/test-utils/recorder/.eslintrc.json @@ -0,0 +1,8 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + "@azure/azure-sdk/ts-package-json-name": "off", + "@azure/azure-sdk/ts-package-json-types": "off" + } +} diff --git a/sdk/test-utils/recorder/package.json b/sdk/test-utils/recorder/package.json index c8f8d6b771fc..9e4471e5f45f 100644 --- a/sdk/test-utils/recorder/package.json +++ b/sdk/test-utils/recorder/package.json @@ -40,7 +40,6 @@ "files": [ "dist/", "dist-esm/src/", - "src/", "typings/src", "README.md", "LICENSE" @@ -49,17 +48,18 @@ "keywords": [ "azure", "recording", + "cloud", "playback" ], "author": "Microsoft Corporation", "license": "MIT", "bugs": { - "url": "https://github.com/azure/azure-sdk-for-js/issues" + "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "engine": { + "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/sdk/test-utils/recorder", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/test-utils/recorder", "sideEffects": false, "private": true, "dependencies": { From b55e8713b328d085749eabfacd948cb614a73bb4 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 13:06:37 -0800 Subject: [PATCH 30/38] perfstress --- sdk/test-utils/perfstress/.eslintrc.json | 9 +++++++++ sdk/test-utils/perfstress/package.json | 3 +-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 sdk/test-utils/perfstress/.eslintrc.json diff --git a/sdk/test-utils/perfstress/.eslintrc.json b/sdk/test-utils/perfstress/.eslintrc.json new file mode 100644 index 000000000000..6319fbfd7e19 --- /dev/null +++ b/sdk/test-utils/perfstress/.eslintrc.json @@ -0,0 +1,9 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + "@azure/azure-sdk/ts-package-json-name": "off", + "@azure/azure-sdk/ts-package-json-main-is-cjs": "off", + "@azure/azure-sdk/ts-package-json-types": "off" + } +} diff --git a/sdk/test-utils/perfstress/package.json b/sdk/test-utils/perfstress/package.json index da4113cd2ef5..df2ee292c8ef 100644 --- a/sdk/test-utils/perfstress/package.json +++ b/sdk/test-utils/perfstress/package.json @@ -37,14 +37,13 @@ "files": [ "dist/", "dist-esm/src/", - "src/", "typings/src", "README.md", "LICENSE" ], "repository": "github:Azure/azure-sdk-for-js", "keywords": [ - "Azure", + "azure", "cloud", "performance", "stress", From 6f09ffc660dcef918d118e9f989d76164e07a2dd Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 13:10:18 -0800 Subject: [PATCH 31/38] digital twins core --- .../digital-twins-core/api-extractor.json | 2 +- sdk/digitaltwins/digital-twins-core/package.json | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/sdk/digitaltwins/digital-twins-core/api-extractor.json b/sdk/digitaltwins/digital-twins-core/api-extractor.json index 35d0cd7711b2..989b6d0383a0 100644 --- a/sdk/digitaltwins/digital-twins-core/api-extractor.json +++ b/sdk/digitaltwins/digital-twins-core/api-extractor.json @@ -11,7 +11,7 @@ "dtsRollup": { "enabled": true, "untrimmedFilePath": "", - "publicTrimmedFilePath": "./types/digitalTwinsClient.d.ts" + "publicTrimmedFilePath": "./types/digital-twins-core.d.ts" }, "messages": { "tsdocMessageReporting": { diff --git a/sdk/digitaltwins/digital-twins-core/package.json b/sdk/digitaltwins/digital-twins-core/package.json index 4521e1bc7afc..aa7cb4a63ed4 100644 --- a/sdk/digitaltwins/digital-twins-core/package.json +++ b/sdk/digitaltwins/digital-twins-core/package.json @@ -7,7 +7,10 @@ "license": "MIT", "main": "dist/index.js", "module": "dist-esm/src/index.js", - "types": "types/digitalTwinsClient.d.ts", + "types": "types/digital-twins-core.d.ts", + "engines": { + "node": ">=8.0.0" + }, "scripts": { "audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit", "build:browser": "tsc -p . && cross-env ONLY_BROWSER=true rollup -c 2>&1", @@ -50,19 +53,17 @@ "azure", "iot", "digital-twins-core", + "cloud", "twins", "node", "typescript", "browser", "isomorphic" ], - "repository": { - "type": "git", - "url": "https://github.com/azure/azure-sdk-for-js.git" - }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/digitaltwins/", + "repository": "github:Azure/azure-sdk-for-js", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/digitaltwins", "bugs": { - "url": "https://github.com/azure/azure-sdk-for-js/issues" + "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, "dependencies": { "@azure/core-http": "^1.2.0", From e3f8ae786127af4ddfcf4f884569962090c9f4e7 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 14:54:55 -0800 Subject: [PATCH 32/38] Address feedback --- sdk/cosmosdb/cosmos/.eslintrc.json | 4 ++-- sdk/storage/storage-blob-changefeed/.eslintrc.json | 3 ++- sdk/storage/storage-blob-changefeed/package.json | 2 +- sdk/storage/storage-internal-avro/api-extractor.json | 2 +- sdk/storage/storage-internal-avro/package.json | 2 +- 5 files changed, 7 insertions(+), 6 deletions(-) diff --git a/sdk/cosmosdb/cosmos/.eslintrc.json b/sdk/cosmosdb/cosmos/.eslintrc.json index 2eb2c2b08c0e..e67e1b7581b9 100644 --- a/sdk/cosmosdb/cosmos/.eslintrc.json +++ b/sdk/cosmosdb/cosmos/.eslintrc.json @@ -9,8 +9,8 @@ "@typescript-eslint/no-extraneous-class": "error", "dot-notation": "off", "some-rule": "off", - "@azure/azure-sdk/ts-package-json-module": "off", - "@azure/azure-sdk/ts-package-json-types": "off", + "@azure/azure-sdk/ts-package-json-module": "warn", + "@azure/azure-sdk/ts-package-json-types": "warn", "@typescript-eslint/tslint/config": [ "error", { diff --git a/sdk/storage/storage-blob-changefeed/.eslintrc.json b/sdk/storage/storage-blob-changefeed/.eslintrc.json index bf70df6fd8eb..8f053942980e 100644 --- a/sdk/storage/storage-blob-changefeed/.eslintrc.json +++ b/sdk/storage/storage-blob-changefeed/.eslintrc.json @@ -2,6 +2,7 @@ "plugins": ["@azure/azure-sdk"], "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], "rules": { - "@azure/azure-sdk/ts-package-json-module": "warn" + "@azure/azure-sdk/ts-package-json-module": "warn", + "@azure/azure-sdk/ts-versioning-semver": "warn" } } diff --git a/sdk/storage/storage-blob-changefeed/package.json b/sdk/storage/storage-blob-changefeed/package.json index fe70e19a89c6..85c4c0f1caf7 100644 --- a/sdk/storage/storage-blob-changefeed/package.json +++ b/sdk/storage/storage-blob-changefeed/package.json @@ -1,7 +1,7 @@ { "name": "@azure/storage-blob-changefeed", "sdk-type": "client", - "version": "12.0.0-beta.3", + "version": "12.0.0-preview.3", "description": "Microsoft Azure Storage SDK for JavaScript - Blob Change Feed", "main": "./dist/index.js", "module": "./dist-esm/storage-blob-changefeed/src/index.js", diff --git a/sdk/storage/storage-internal-avro/api-extractor.json b/sdk/storage/storage-internal-avro/api-extractor.json index 6b50cf6b2ecc..c10df8f8e06d 100644 --- a/sdk/storage/storage-internal-avro/api-extractor.json +++ b/sdk/storage/storage-internal-avro/api-extractor.json @@ -1,6 +1,6 @@ { "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", - "mainEntryPointFilePath": "typings/latest/src/index.d.ts", + "mainEntryPointFilePath": "types/latest/src/index.d.ts", "docModel": { "enabled": false }, diff --git a/sdk/storage/storage-internal-avro/package.json b/sdk/storage/storage-internal-avro/package.json index 3eb008df477a..df7b4cd59e90 100644 --- a/sdk/storage/storage-internal-avro/package.json +++ b/sdk/storage/storage-internal-avro/package.json @@ -42,7 +42,7 @@ "build:nodebrowser": "rollup -c 2>&1", "build:samples": "echo Skipped.", "build:test": "npm run build:es6 && rollup -c rollup.test.config.js 2>&1", - "build:types": "downlevel-dts typings/latest typings/3.1", + "build:types": "downlevel-dts types/latest types/3.1", "build": "npm run build:es6 && npm run build:nodebrowser && api-extractor run --local && npm run build:types", "check-format": "prettier --list-different --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"*.{js,json}\"", "clean": "rimraf dist dist-esm dist-test typings temp dist-browser/*.js* dist-browser/*.zip statistics.html coverage coverage-browser .nyc_output *.tgz *.log test*.xml TEST*.xml", From 06a1cb25f359bd28b816f9ee4dbe6f3f6f065164 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 15:13:42 -0800 Subject: [PATCH 33/38] fix schema-registry link --- sdk/schemaregistry/schema-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/schemaregistry/schema-registry/package.json b/sdk/schemaregistry/schema-registry/package.json index fb7c81ee40f0..73ced8adbd32 100644 --- a/sdk/schemaregistry/schema-registry/package.json +++ b/sdk/schemaregistry/schema-registry/package.json @@ -73,7 +73,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry/", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { From 5c61e09b302d4485eb1236087b141bba867b616a Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 17:59:24 -0800 Subject: [PATCH 34/38] Revert "Fix linting rule for ts-package-json-homepage" This reverts commit bd3df53af526f1e6704786f403fb9047ce1a3864. --- .../docs/rules/ts-package-json-homepage.md | 6 ------ .../src/rules/ts-package-json-homepage.ts | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md index 4671fce07d20..3526cf8173da 100644 --- a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md +++ b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md @@ -32,12 +32,6 @@ Requires `homepage` in `package.json` to be set to the library's readme. } ``` -```json -{ - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/" -} -``` - ```json { "homepage": "https://github.com/Azure/azure-sdk-for-java/blob/master/sdk/servicebus/service-bus/README.md" diff --git a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts index 74ca116a8525..07d1ec1b3e61 100644 --- a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts +++ b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-homepage.ts @@ -37,7 +37,7 @@ export = { const nodeValue = node.value as Literal; if ( - !/^https:\/\/github.com\/Azure\/azure-sdk-for-js\/(blob|tree)\/master\/sdk(\/([a-z]+-)*[a-z]+)+(\/README\.md)?$/.test( + !/^https:\/\/github.com\/Azure\/azure-sdk-for-js\/(blob|tree)\/master\/sdk\/(([a-z]+-)*[a-z]+\/)+(README\.md)?$/.test( nodeValue.value as string ) ) { From 97f6b78b482b6d9a502f75f1caf7f5f505329398 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 18:11:08 -0800 Subject: [PATCH 35/38] Revert homepage rule --- .../docs/rules/ts-package-json-homepage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md index 3526cf8173da..6618339904b4 100644 --- a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md +++ b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-homepage.md @@ -14,7 +14,7 @@ Requires `homepage` in `package.json` to be set to the library's readme. ```json { - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus" + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/servicebus/service-bus/" } ``` From c23bbe50e1efc1e40106cd1969171d62e5eddf12 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Tue, 5 Jan 2021 18:28:23 -0800 Subject: [PATCH 36/38] standardize homepage paths --- common/tools/dev-tool/package.json | 2 +- common/tools/eslint-plugin-azure-sdk/package.json | 2 +- sdk/anomalydetector/ai-anomaly-detector/package.json | 2 +- sdk/appconfiguration/app-configuration/package.json | 2 +- sdk/communication/communication-administration/package.json | 2 +- sdk/communication/communication-chat/package.json | 2 +- sdk/communication/communication-common/package.json | 2 +- sdk/communication/communication-sms/package.json | 2 +- sdk/core/core-client/package.json | 2 +- sdk/core/core-https/package.json | 2 +- sdk/core/core-xml/package.json | 2 +- sdk/cosmosdb/cosmos/package.json | 2 +- sdk/digitaltwins/digital-twins-core/package.json | 2 +- sdk/eventhub/event-hubs/package.json | 2 +- sdk/eventhub/event-processor-host/package.json | 2 +- sdk/eventhub/eventhubs-checkpointstore-blob/package.json | 2 +- sdk/formrecognizer/ai-form-recognizer/package.json | 2 +- sdk/monitor/opentelemetry-exporter-azure-monitor/package.json | 2 +- sdk/schemaregistry/schema-registry-avro/package.json | 2 +- sdk/schemaregistry/schema-registry/package.json | 2 +- sdk/search/search-documents/package.json | 2 +- sdk/servicebus/service-bus/package.json | 2 +- sdk/storage/storage-blob-changefeed/package.json | 2 +- sdk/storage/storage-blob/package.json | 2 +- sdk/storage/storage-file-datalake/package.json | 2 +- sdk/storage/storage-file-share/package.json | 2 +- sdk/storage/storage-internal-avro/package.json | 2 +- sdk/storage/storage-queue/package.json | 2 +- sdk/tables/data-tables/package.json | 2 +- sdk/template/template/package.json | 2 +- sdk/test-utils/recorder/package.json | 2 +- 31 files changed, 31 insertions(+), 31 deletions(-) diff --git a/common/tools/dev-tool/package.json b/common/tools/dev-tool/package.json index 8b1eb7ef65c5..6d9890195315 100644 --- a/common/tools/dev-tool/package.json +++ b/common/tools/dev-tool/package.json @@ -30,7 +30,7 @@ "bugs": { "url": "https://github.com/azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/common/tools/dev-tool", + "homepage": "https://github.com/azure/azure-sdk-for-js/tree/master/common/tools/dev-tool/", "sideEffects": false, "private": true, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", diff --git a/common/tools/eslint-plugin-azure-sdk/package.json b/common/tools/eslint-plugin-azure-sdk/package.json index 632a36e49fd1..b4fb7fb4a54c 100644 --- a/common/tools/eslint-plugin-azure-sdk/package.json +++ b/common/tools/eslint-plugin-azure-sdk/package.json @@ -21,7 +21,7 @@ } ], "license": "MIT", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/common/tools/eslint-plugin-azure-sdk", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/common/tools/eslint-plugin-azure-sdk/", "repository": { "type": "git", "url": "https://github.com/Azure/azure-sdk-for-js.git", diff --git a/sdk/anomalydetector/ai-anomaly-detector/package.json b/sdk/anomalydetector/ai-anomaly-detector/package.json index 0bfeffa953f2..9a5615b70ba1 100644 --- a/sdk/anomalydetector/ai-anomaly-detector/package.json +++ b/sdk/anomalydetector/ai-anomaly-detector/package.json @@ -58,7 +58,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/anomalydetector/ai-anomaly-detector", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/anomalydetector/ai-anomaly-detector/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/appconfiguration/app-configuration/package.json b/sdk/appconfiguration/app-configuration/package.json index b2468f22b0ae..e2dfad23f799 100644 --- a/sdk/appconfiguration/app-configuration/package.json +++ b/sdk/appconfiguration/app-configuration/package.json @@ -16,7 +16,7 @@ "main": "./dist/index.js", "module": "./dist-esm/src/index.js", "types": "./types/app-configuration.d.ts", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/appconfiguration/app-configuration", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/appconfiguration/app-configuration/", "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" diff --git a/sdk/communication/communication-administration/package.json b/sdk/communication/communication-administration/package.json index 53b8501e6a90..32f2f3cb9a83 100644 --- a/sdk/communication/communication-administration/package.json +++ b/sdk/communication/communication-administration/package.json @@ -59,7 +59,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-administration", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-administration/", "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json index 2c12001d0da5..c3ba2a4879d5 100644 --- a/sdk/communication/communication-chat/package.json +++ b/sdk/communication/communication-chat/package.json @@ -60,7 +60,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-chat", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-chat/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/communication/communication-common/package.json b/sdk/communication/communication-common/package.json index 541848ce05c1..41849fc95a72 100644 --- a/sdk/communication/communication-common/package.json +++ b/sdk/communication/communication-common/package.json @@ -59,7 +59,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-common", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-common/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/communication/communication-sms/package.json b/sdk/communication/communication-sms/package.json index 09957db9abdf..41f841318fa1 100644 --- a/sdk/communication/communication-sms/package.json +++ b/sdk/communication/communication-sms/package.json @@ -63,7 +63,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-sms", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/communication/communication-sms/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/core/core-client/package.json b/sdk/core/core-client/package.json index 423985f81e43..1569729ebe72 100644 --- a/sdk/core/core-client/package.json +++ b/sdk/core/core-client/package.json @@ -72,7 +72,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-client", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-client/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/core/core-https/package.json b/sdk/core/core-https/package.json index 1c140d8e2bb8..1f2d75409fae 100644 --- a/sdk/core/core-https/package.json +++ b/sdk/core/core-https/package.json @@ -76,7 +76,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-https", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-https/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "//metadata": { diff --git a/sdk/core/core-xml/package.json b/sdk/core/core-xml/package.json index 7e07fee06d7b..00ed1b0ad22b 100644 --- a/sdk/core/core-xml/package.json +++ b/sdk/core/core-xml/package.json @@ -71,7 +71,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-xml", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/core/core-xml/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/cosmosdb/cosmos/package.json b/sdk/cosmosdb/cosmos/package.json index 8626678ab206..4febf65a4b8d 100644 --- a/sdk/cosmosdb/cosmos/package.json +++ b/sdk/cosmosdb/cosmos/package.json @@ -32,7 +32,7 @@ "README.md", "LICENSE" ], - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/cosmosdb/cosmos/", "sideEffects": false, "types": "./dist/types/latest/index.d.ts", "typesVersions": { diff --git a/sdk/digitaltwins/digital-twins-core/package.json b/sdk/digitaltwins/digital-twins-core/package.json index aa7cb4a63ed4..423b7f29da28 100644 --- a/sdk/digitaltwins/digital-twins-core/package.json +++ b/sdk/digitaltwins/digital-twins-core/package.json @@ -61,7 +61,7 @@ "isomorphic" ], "repository": "github:Azure/azure-sdk-for-js", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/digitaltwins", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/digitaltwins/digital-twins-core/", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, diff --git a/sdk/eventhub/event-hubs/package.json b/sdk/eventhub/event-hubs/package.json index 2531dc4e84a0..da92224a137c 100644 --- a/sdk/eventhub/event-hubs/package.json +++ b/sdk/eventhub/event-hubs/package.json @@ -5,7 +5,7 @@ "description": "Azure Event Hubs SDK for JS.", "author": "Microsoft Corporation", "license": "MIT", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-hubs", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-hubs/", "repository": "github:Azure/azure-sdk-for-js", "sideEffects": false, "keywords": [ diff --git a/sdk/eventhub/event-processor-host/package.json b/sdk/eventhub/event-processor-host/package.json index 4ea3f537fc87..8f46eb13f18a 100644 --- a/sdk/eventhub/event-processor-host/package.json +++ b/sdk/eventhub/event-processor-host/package.json @@ -5,7 +5,7 @@ "description": "Azure Event Processor Host (Event Hubs) SDK for JS.", "author": "Microsoft Corporation", "license": "MIT", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-processor-host", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/event-processor-host/", "repository": "github:Azure/azure-sdk-for-js", "sideEffects": false, "keywords": [ diff --git a/sdk/eventhub/eventhubs-checkpointstore-blob/package.json b/sdk/eventhub/eventhubs-checkpointstore-blob/package.json index 6f06c04162c9..bb220f53178f 100644 --- a/sdk/eventhub/eventhubs-checkpointstore-blob/package.json +++ b/sdk/eventhub/eventhubs-checkpointstore-blob/package.json @@ -5,7 +5,7 @@ "description": "An Azure Storage Blob solution to store checkpoints when using Event Hubs.", "author": "Microsoft Corporation", "license": "MIT", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/eventhubs-checkpointstore-blob", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/eventhub/eventhubs-checkpointstore-blob/", "repository": "github:Azure/azure-sdk-for-js", "sideEffects": false, "keywords": [ diff --git a/sdk/formrecognizer/ai-form-recognizer/package.json b/sdk/formrecognizer/ai-form-recognizer/package.json index 3cd65d6c3154..71fcd09d6adb 100644 --- a/sdk/formrecognizer/ai-form-recognizer/package.json +++ b/sdk/formrecognizer/ai-form-recognizer/package.json @@ -19,7 +19,7 @@ "./dist-esm/src/utils/utils.node.js": "./dist-esm/src/utils/utils.browser.js" }, "types": "./types/ai-form-recognizer.d.ts", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/formrecognizer/ai-form-recognizer", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/formrecognizer/ai-form-recognizer/", "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json index 7fb3996ba541..420184f96c2f 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json @@ -47,7 +47,7 @@ "LICENSE" ], "license": "MIT", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/monitor/opentelemetry-exporter-azure-monitor", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/monitor/opentelemetry-exporter-azure-monitor/", "repository": "github:Azure/azure-sdk-for-js", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" diff --git a/sdk/schemaregistry/schema-registry-avro/package.json b/sdk/schemaregistry/schema-registry-avro/package.json index 2b7a758bd5f3..4711d236bd1e 100644 --- a/sdk/schemaregistry/schema-registry-avro/package.json +++ b/sdk/schemaregistry/schema-registry-avro/package.json @@ -57,7 +57,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry-avro", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry-avro/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/schemaregistry/schema-registry/package.json b/sdk/schemaregistry/schema-registry/package.json index 73ced8adbd32..fb7c81ee40f0 100644 --- a/sdk/schemaregistry/schema-registry/package.json +++ b/sdk/schemaregistry/schema-registry/package.json @@ -73,7 +73,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/schemaregistry/schema-registry/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/search/search-documents/package.json b/sdk/search/search-documents/package.json index bd940e6905ba..b1c3d0258975 100644 --- a/sdk/search/search-documents/package.json +++ b/sdk/search/search-documents/package.json @@ -72,7 +72,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/search/search-documents", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/search/search-documents/", "sideEffects": false, "dependencies": { "@azure/core-auth": "^1.1.3", diff --git a/sdk/servicebus/service-bus/package.json b/sdk/servicebus/service-bus/package.json index 49af3ba4e470..db2e8f6b5064 100644 --- a/sdk/servicebus/service-bus/package.json +++ b/sdk/servicebus/service-bus/package.json @@ -5,7 +5,7 @@ "version": "7.0.1", "license": "MIT", "description": "Azure Service Bus SDK for JavaScript", - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/servicebus/service-bus", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/servicebus/service-bus/", "repository": "github:Azure/azure-sdk-for-js", "keywords": [ "azure", diff --git a/sdk/storage/storage-blob-changefeed/package.json b/sdk/storage/storage-blob-changefeed/package.json index 85c4c0f1caf7..91234539807a 100644 --- a/sdk/storage/storage-blob-changefeed/package.json +++ b/sdk/storage/storage-blob-changefeed/package.json @@ -83,7 +83,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob-changefeed", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob-changefeed/", "sideEffects": false, "//metadata": { "constantPaths": [ diff --git a/sdk/storage/storage-blob/package.json b/sdk/storage/storage-blob/package.json index 35f0c8a81245..0831ada96904 100644 --- a/sdk/storage/storage-blob/package.json +++ b/sdk/storage/storage-blob/package.json @@ -89,7 +89,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-blob/", "sideEffects": false, "//metadata": { "constantPaths": [ diff --git a/sdk/storage/storage-file-datalake/package.json b/sdk/storage/storage-file-datalake/package.json index 2f85a82f0ad2..eacc57d66164 100644 --- a/sdk/storage/storage-file-datalake/package.json +++ b/sdk/storage/storage-file-datalake/package.json @@ -86,7 +86,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-datalake", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-datalake/", "//metadata": { "constantPaths": [ { diff --git a/sdk/storage/storage-file-share/package.json b/sdk/storage/storage-file-share/package.json index 331974c1dd27..c72811c8e8c6 100644 --- a/sdk/storage/storage-file-share/package.json +++ b/sdk/storage/storage-file-share/package.json @@ -83,7 +83,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-share", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-file-share/", "sideEffects": false, "//metadata": { "constantPaths": [ diff --git a/sdk/storage/storage-internal-avro/package.json b/sdk/storage/storage-internal-avro/package.json index df7b4cd59e90..b9c26e361275 100644 --- a/sdk/storage/storage-internal-avro/package.json +++ b/sdk/storage/storage-internal-avro/package.json @@ -7,7 +7,7 @@ "description": "internal avro parser", "license": "MIT", "repository": "github:Azure/azure-sdk-for-js", - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-internal-avro", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-internal-avro/", "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, diff --git a/sdk/storage/storage-queue/package.json b/sdk/storage/storage-queue/package.json index 2f6c9af75112..f9568115e087 100644 --- a/sdk/storage/storage-queue/package.json +++ b/sdk/storage/storage-queue/package.json @@ -80,7 +80,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-queue", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/storage/storage-queue/", "sideEffects": false, "//metadata": { "constantPaths": [ diff --git a/sdk/tables/data-tables/package.json b/sdk/tables/data-tables/package.json index 15a10abdb101..cbf2646c1351 100644 --- a/sdk/tables/data-tables/package.json +++ b/sdk/tables/data-tables/package.json @@ -62,7 +62,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/tables/data-tables", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/tables/data-tables/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/template/template/package.json b/sdk/template/template/package.json index 0ac4132974a8..45445a5d22dc 100644 --- a/sdk/template/template/package.json +++ b/sdk/template/template/package.json @@ -57,7 +57,7 @@ "bugs": { "url": "https://github.com/Azure/azure-sdk-for-js/issues" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/template/template", + "homepage": "https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/template/template/", "sideEffects": false, "prettier": "@azure/eslint-plugin-azure-sdk/prettier.json", "dependencies": { diff --git a/sdk/test-utils/recorder/package.json b/sdk/test-utils/recorder/package.json index 9e4471e5f45f..f836be9c21a7 100644 --- a/sdk/test-utils/recorder/package.json +++ b/sdk/test-utils/recorder/package.json @@ -59,7 +59,7 @@ "engines": { "node": ">=8.0.0" }, - "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/test-utils/recorder", + "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/test-utils/recorder/", "sideEffects": false, "private": true, "dependencies": { From 28984d1314978da5fdc6dd5553c25582c4fba7b2 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Wed, 6 Jan 2021 13:54:06 -0800 Subject: [PATCH 37/38] Allow overriding node version in package.json --- common/config/rush/pnpm-lock.yaml | 11 ++++- .../ts-package-json-engine-is-present.md | 42 +++++++++++++++---- .../eslint-plugin-azure-sdk/package.json | 2 + .../ts-package-json-engine-is-present.ts | 28 +++++++++---- .../src/utils/metadata.ts | 6 ++- .../ts-package-json-engine-is-present.ts | 26 ++++++++++++ .../.eslintrc.json | 8 +++- .../README.md | 2 +- .../package.json | 2 +- 9 files changed, 106 insertions(+), 21 deletions(-) diff --git a/common/config/rush/pnpm-lock.yaml b/common/config/rush/pnpm-lock.yaml index e177e1606876..67e00376c810 100644 --- a/common/config/rush/pnpm-lock.yaml +++ b/common/config/rush/pnpm-lock.yaml @@ -4374,6 +4374,10 @@ packages: dev: false resolution: integrity: sha1-tIDIkuWaLwWVTOcnvT8qTogvnhM= + /json-schema/0.3.0: + dev: false + resolution: + integrity: sha512-TYfxx36xfl52Rf1LU9HyWSLGPdYLL+SQ8/E/0yVyKG8wCCDaSrhPap0vEdlsZWRaS6tnKKLPGiEJGiREVC8kxQ== /json-stable-stringify-without-jsonify/1.0.1: dev: false resolution: @@ -9041,6 +9045,7 @@ packages: karma-remap-istanbul: 0.6.0_karma@5.2.3 mocha: 7.2.0 mocha-junit-reporter: 1.23.3_mocha@7.2.0 + nyc: 14.1.1 prettier: 1.19.1 rimraf: 3.0.2 rollup: 1.32.1 @@ -9056,7 +9061,7 @@ packages: dev: false name: '@rush-temp/data-tables' resolution: - integrity: sha512-q7N2kw0AD/INh87gkzzATH88kOQ6/qO78ipb8D0vRin+En7CUV1/fo7jZzl1dM5lGTWeneGYQ7aWOcXrw6pInA== + integrity: sha512-4Rw9bJONHF4b63GMcRXMMedfBfpmEfz/sXPYQrXZJuXm48X+kZp5TVYLxmgjAOUBozyCv7U9cGK2DWPBpesPyA== tarball: 'file:projects/data-tables.tgz' version: 0.0.0 'file:projects/dev-tool.tgz': @@ -9154,6 +9159,7 @@ packages: '@types/eslint': 7.2.6 '@types/estree': 0.0.45 '@types/glob': 7.1.3 + '@types/json-schema': 7.0.6 '@types/mocha': 7.0.2 '@types/node': 8.10.66 '@typescript-eslint/eslint-plugin': 4.10.0_6293af56a321af96e1696de9ab377ba5 @@ -9167,6 +9173,7 @@ packages: eslint-plugin-promise: 4.2.1 eslint-plugin-tsdoc: 0.2.10 glob: 7.1.6 + json-schema: 0.3.0 mocha: 7.2.0 mocha-junit-reporter: 1.23.3_mocha@7.2.0 prettier: 1.19.1 @@ -9178,7 +9185,7 @@ packages: dev: false name: '@rush-temp/eslint-plugin-azure-sdk' resolution: - integrity: sha512-NmCxr5BwG6llNiPN2tnOIOQ3s6yungwTUIrG79tJOKe+Z+FA2BZD933217k6pyyUfkAHB7LFn604ZKjpxRZkgg== + integrity: sha512-Gqr+hJ1efEQ00ZfMuHixctG31SOocfl9ENhDjzlebnDuNhYlcAb95K4XQDzhYU2mv7mv5ESwByaJoBbQM5+jQw== tarball: 'file:projects/eslint-plugin-azure-sdk.tgz' version: 0.0.0 'file:projects/event-hubs.tgz': diff --git a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-engine-is-present.md b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-engine-is-present.md index a342ef0800b0..a6225be3db8a 100644 --- a/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-engine-is-present.md +++ b/common/tools/eslint-plugin-azure-sdk/docs/rules/ts-package-json-engine-is-present.md @@ -2,7 +2,7 @@ Requires support for all Node LTS version. -Currently, this requires `engine` in `package.json` to be set to `">=8.0.0"`. +Currently, this requires `engines` in `package.json` to contain an entry for `node` set to `">=8.0.0"` unless a `nodeVersionOverride` value is present. This rule is fixable using the `--fix` option. @@ -12,23 +12,33 @@ This rule is fixable using the `--fix` option. ```json { - "engine": ">=8.0.0" + "engines": { + "node": ">=8.0.0" + } } ``` ### Bad -````json +```json { - "engine": ">=6.0.0" + "engine": { + "node": ">=8.0.0" + } } -```' +``` ```json { - "engine": ">=10.0.0" + "engine": ">=6.0.0" } -```` +``` + +```json +{ + "engine": ">=10.0.0" +} +``` ```json {} @@ -38,6 +48,24 @@ This rule is fixable using the `--fix` option. Only if the rule breaks. +## Options + +This rule as an object option: + +- `"nodeVersionOverride"`: allow providing a custom supported node version if an external dependency enforces it + +### nodeVersionOverride + +Example of **correct** code for this rule with the `{ "nodeVersionOverride": ">=10.0.0" }` option: + +```json +{ + "engines": { + "node": ">=10.0.0" + } +} +``` + ## [Source](https://azure.github.io/azure-sdk/typescript_implementation.html#ts-package-json-engine-is-present) Also encompasses [ts-node-support](https://azure.github.io/azure-sdk/typescript_design.html#ts-node-support), as the rules are similar enough to not exist separately for linting purposes. diff --git a/common/tools/eslint-plugin-azure-sdk/package.json b/common/tools/eslint-plugin-azure-sdk/package.json index b4fb7fb4a54c..5eaa6716c903 100644 --- a/common/tools/eslint-plugin-azure-sdk/package.json +++ b/common/tools/eslint-plugin-azure-sdk/package.json @@ -72,12 +72,14 @@ "@types/estree": "^0.0.45", "eslint-config-prettier": "^7.0.0", "glob": "^7.1.2", + "json-schema": "^0.3.0", "typescript": "4.1.2", "tslib": "^2.0.0" }, "devDependencies": { "@types/chai": "^4.1.6", "@types/glob": "^7.1.1", + "@types/json-schema": "^7.0.6", "@types/mocha": "^7.0.2", "@types/node": "^8.0.0", "@typescript-eslint/eslint-plugin": "^4.9.0", diff --git a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-engine-is-present.ts b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-engine-is-present.ts index 46ce0b458204..50aabaa89d8c 100644 --- a/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-engine-is-present.ts +++ b/common/tools/eslint-plugin-azure-sdk/src/rules/ts-package-json-engine-is-present.ts @@ -9,6 +9,12 @@ import { Rule } from "eslint"; import { getRuleMetaData, getVerifiers, stripPath } from "../utils"; +/** + * definition of LTS Node versions + * * needs updating as definitions change + */ +const LTS = ">=8.0.0"; + //------------------------------------------------------------------------------ // Rule Definition //------------------------------------------------------------------------------ @@ -17,19 +23,27 @@ export = { meta: getRuleMetaData( "ts-package-json-engine-is-present", "force Node support for all LTS versions", - "code" + "code", + [ + { + type: "object", + properties: { + nodeVersionOverride: { + type: "string", + default: LTS, + description: "Allows specifying a different node version than the current default" + } + } + } + ] ), create: (context: Rule.RuleContext): Rule.RuleListener => { - /** - * definition of LTS Node versions - * * needs updating as definitions change - */ - const LTS = ">=8.0.0"; + const options = context.options[0] || {}; const verifiers = getVerifiers(context, { outer: "engines", inner: "node", - expected: LTS + expected: options.nodeVersionOverride || LTS }); return stripPath(context.getFilename()) === "package.json" ? ({ diff --git a/common/tools/eslint-plugin-azure-sdk/src/utils/metadata.ts b/common/tools/eslint-plugin-azure-sdk/src/utils/metadata.ts index e4e67fd677da..fa81e7302fb4 100644 --- a/common/tools/eslint-plugin-azure-sdk/src/utils/metadata.ts +++ b/common/tools/eslint-plugin-azure-sdk/src/utils/metadata.ts @@ -7,11 +7,13 @@ */ import { Rule } from "eslint"; +import { JSONSchema4 } from "json-schema"; export const getRuleMetaData = ( ruleName: string, ruleDescription: string, - fix?: "code" | "whitespace" + fix?: "code" | "whitespace", + schema?: JSONSchema4 | JSONSchema4[] ): Rule.RuleMetaData => { const required = { type: "suggestion", @@ -21,7 +23,7 @@ export const getRuleMetaData = ( recommended: true, url: `https://github.com/Azure/azure-sdk-for-js/tree/master/common/tools/eslint-plugin-azure-sdk/docs/rules/${ruleName}.md` }, - schema: [] + schema: schema || [] }; return (fix !== undefined ? { ...required, fixable: fix } : required) as Rule.RuleMetaData; }; diff --git a/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-engine-is-present.ts b/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-engine-is-present.ts index 328a20da1d8d..8810059d534a 100644 --- a/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-engine-is-present.ts +++ b/common/tools/eslint-plugin-azure-sdk/tests/rules/ts-package-json-engine-is-present.ts @@ -269,6 +269,16 @@ ruleTester.run("ts-package-json-engine-is-present", rule, { // incorrect format but in a file we don't care about code: '{"engines": { "node": ">=6.0.0" }}', filename: "not_package.json" + }, + { + // different than the default but with an override + code: '{"engines": { "node": ">=8.5.0" }}', + filename: "package.json", + options: [ + { + nodeVersionOverride: ">=8.5.0" + } + ] } ], invalid: [ @@ -322,6 +332,22 @@ ruleTester.run("ts-package-json-engine-is-present", rule, { } ], output: examplePackageGood + }, + { + // override was provided but the version does not match + code: '{"engines": { "node": ">=8.0.0" }}', + filename: "package.json", + errors: [ + { + message: "engines.node is set to >=8.0.0 when it should be set to >=6.5.0" + } + ], + options: [ + { + nodeVersionOverride: ">=6.5.0" + } + ], + output: '{"engines": { "node": ">=6.5.0" }}' } ] }); diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/.eslintrc.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/.eslintrc.json index c74136d13cf1..49ba262b614f 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/.eslintrc.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/.eslintrc.json @@ -12,6 +12,12 @@ ], "rules": { "no-underscore-dangle": ["error", { "allowAfterThis": true }], - "node/no-unsupported-features/es-syntax": ["error", { "ignores": ["modules"] }] + "node/no-unsupported-features/es-syntax": ["error", { "ignores": ["modules"] }], + // OpenTelemetry requires a minimum node version of 8.5.0 + // https://github.com/open-telemetry/opentelemetry-js#node-support + "@azure/azure-sdk/ts-package-json-engine-is-present": [ + "error", + { "nodeVersionOverride": ">=8.5.0" } + ] } } diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/README.md b/sdk/monitor/opentelemetry-exporter-azure-monitor/README.md index 4a397a35bd06..5bdadffe332d 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/README.md +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/README.md @@ -14,7 +14,7 @@ This exporter package assumes your application is [already instrumented](https:/ You must have an [Azure subscription](https://azure.microsoft.com/free/) and a [Application Insights workspace](https://docs.microsoft.com/azure/azure-monitor/app/app-insights-overview/) to use this package. -If you are using this package in a Node.js application, then use Node.js 8.x or higher. +If you are using this package in a Node.js application, then use Node.js 8.5.0 or higher. ### Distributed Tracing diff --git a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json index 420184f96c2f..62931380e6e6 100644 --- a/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json +++ b/sdk/monitor/opentelemetry-exporter-azure-monitor/package.json @@ -35,7 +35,7 @@ "docs": "typedoc --excludePrivate --excludeNotExported --excludeExternals --mode file --out ./dist/docs ./src" }, "engines": { - "node": ">=8.0.0" + "node": ">=8.5.0" }, "files": [ "dist-esm/src/", From 0823b123d2c9bddee8afb2158ce2c9e276146c90 Mon Sep 17 00:00:00 2001 From: Maor Leger Date: Thu, 7 Jan 2021 08:13:59 -0800 Subject: [PATCH 38/38] ship src in communication-chat and set linter to warn --- sdk/communication/communication-chat/.eslintrc.json | 8 ++++++++ sdk/communication/communication-chat/package.json | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 sdk/communication/communication-chat/.eslintrc.json diff --git a/sdk/communication/communication-chat/.eslintrc.json b/sdk/communication/communication-chat/.eslintrc.json new file mode 100644 index 000000000000..a33aa33c57d9 --- /dev/null +++ b/sdk/communication/communication-chat/.eslintrc.json @@ -0,0 +1,8 @@ +{ + "plugins": ["@azure/azure-sdk"], + "extends": ["plugin:@azure/azure-sdk/azure-sdk-base"], + "rules": { + // Removing `src` would be a breaking change so leaving it for the package owners to address + "@azure/azure-sdk/ts-package-json-files-required": "warn" + } +} diff --git a/sdk/communication/communication-chat/package.json b/sdk/communication/communication-chat/package.json index c3ba2a4879d5..a28abbd89ce0 100644 --- a/sdk/communication/communication-chat/package.json +++ b/sdk/communication/communication-chat/package.json @@ -39,7 +39,8 @@ "dist-esm/src/", "types/", "README.md", - "LICENSE" + "LICENSE", + "src" ], "browser": { "./dist-esm/src/signaling/signalingClient.js": "./dist-esm/src/signaling/signalingClient.browser.js"